Community
Participate
Working Groups
Bug 248917 introduced a new field in the files table to handle the plugin id, so that we don't use a regexp to determine the plugin id during the lang pack generation. This is very useful when we use Babel over repositories that don't respect the particular layout Eclipse forces on repositories. However this change was not affecting generate1.php as it had been heavily modified at the time.
Created attachment 117434 [details] The patch Adding the patch - please approve and I will commit.
Antoine, untill bug 254429 is fixed, there is still a possibility that the plugin_id from file_row is blank. Shouldn't we fallback to the old way of extracting the plugin_id from the file name when the plugin_id from file_row is blank?
As 254459 states, that row is empty only in the case that the file is not processed because it was deleted before the use of the plugin id. Those files are not in the map files anymore and we should not be generating them in the first place. I agree we should fix 254429 one way or another before marking this issue as fixed.
