Bug 252498 - [clean up] Improve exception handling (allow user to disable)
Summary: [clean up] Improve exception handling (allow user to disable)
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-28 16:48 EDT by Benjamin Muskalla CLA
Modified: 2008-10-29 05:57 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2008-10-28 16:48:02 EDT 
I20081028-0100

Throwing exceptions in the constructor gracefully disables the according cleanup ui and present the problem to the user.
Exceptions in other methods (eg getCleanUpCount) are catched but only logged without the knowledge of the user.
I think all exceptions in the contributed cleanup ui should be handled by disabling the UI of this cleanup. If not this could lead to real problems as the cleanup uses options the user may not have chosen.
Comment 1 Dani Megert CLA 2008-10-29 05:57:28 EDT 
The count and the selection count are really just for user information and there's no harm if this is wrong. Also, if there's a one time exception - maybe due to a corrupt file - we should not disable but let the user decide (like we do with failing completion processors).