Bug 252321 - Importing org.sat4j.pb does not work
Summary: Importing org.sat4j.pb does not work
Status: VERIFIED DUPLICATE of bug 252392
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-28 06:10 EDT by Dani Megert CLA
Modified: 2008-10-29 05:36 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2008-10-28 06:10:10 EDT 
I20081027-1300.

Importing org.sat4j.pb does not work.

1. start fresh workspace
2. import org.sat4j.pb as binary plug-in
==> compile error that a library is missing.

Shot in the dark: related to bug 250946?


If found this in a larger context where I wanted to setup a workspace with PDE UI and all required plug-ins as binary plug-ins:

1. start fresh workspace
2. disable all target plug-ins
3. checkout pde.ui from CVS
   ==> compile errors (expected)
4. import all required plug-ins
==> no way to make the workspace error free
Comment 1 Chris Aniszczyk CLA 2008-10-28 10:53:54 EDT 
I believe the problems are related.
Comment 2 Jerome Lanneluc CLA 2008-10-28 11:30:38 EDT 
Looks like a dup of bug 252392
Comment 3 Chris Aniszczyk CLA 2008-10-28 11:31:30 EDT 
Pascal, was the sat4j bundle ever fixed to remove this header:

Class-Path: org.sat4j.core.jar

I believe JDT still has issues with that
Comment 4 Dani Megert CLA 2008-10-28 11:33:34 EDT 
Note that so far this was not a blocker because PDE UI did not require p2.ui and hence no need to import sat4j. Now it is.
Comment 5 Chris Aniszczyk CLA 2008-10-28 11:35:22 EDT 
(In reply to comment #4)
> Note that so far this was not a blocker because PDE UI did not require p2.ui
> and hence no need to import sat4j. Now it is.

But it's about time we use p2 ;) So I understand that's the point.

The problem is still that the MANIFEST.MF of the sat4j pb bundle is wrong. I checked in the Orbit branch and I still see the wrong header.
Comment 6 Olivier Thomann CLA 2008-10-28 11:39:37 EDT 
The header is only used outside of Eclipse.
See bug 250946 comment 19.
Sat4J should not require the referenced jar to be there inside the IDE.
Comment 7 Chris Aniszczyk CLA 2008-10-28 11:47:36 EDT 
moving to the p2 team as they control the bundle in Orbit.
Comment 8 Chris Aniszczyk CLA 2008-10-28 11:48:13 EDT 
btw, the sat4j bundle is also missing export package version #s if you want to kill two birds with one stone
Comment 9 Dani Megert CLA 2008-10-28 12:58:51 EDT 
Reducing severity: I can go on if I uncheck
Java > Compiler > Building | Build path problems
  [ ] Abort build when build path errors occur
Comment 10 Pascal Rapicault CLA 2008-10-28 13:54:27 EDT 
To me, the problem lies at the intersection of PDE and JDT and not the bundle for which we do *not* own the manifest. Indeed the sat4j jars are meant to be run both in a standalone environment (out of the box on the sat4j download site the sat4j.pb.jar properly refers to a sat4j.core jar) and in an OSGi environment (which is why they come with a manifest).

What I would expect to see happening here is that for JDT to realize that org.sat4j.pb is handled by PDE and not apply its Classpath magic.
Also I would expect this to not be set as an error by default.
Comment 11 Pascal Rapicault CLA 2008-10-28 13:55:00 EDT 
Moving back to JDT core.
Comment 12 Jerome Lanneluc CLA 2008-10-28 14:03:30 EDT 

*** This bug has been marked as a duplicate of bug 252392 ***
Comment 13 David Audel CLA 2008-10-29 05:36:57 EDT 
Verified for 3.5M3 using I20081028-2000 build.