Bug 252298 - launcher artifact empty after product export
Summary: launcher artifact empty after product export
Status: NEW
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows Vista
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-27 23:01 EDT by Jeff McAffer CLA
Modified: 2022-11-14 11:41 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff McAffer CLA 2008-10-27 23:01:03 EDT
in m2 and 3.4.1

- define a product configuration
- add the launcher bundle and fragment to the list of plugins
- export the product and select the "generate metadata..." box
- after the export completes there is a <product name>.launcher.os.ws.arch artifact in the binary part of the artifact repo but on my machine it is empty.

Note that I have tried this with and without the deltapack in the target platform.  The problem seems to happen regardless of whether the target platform is a .target definition or the IDE itself.  

I have also reproduced this in new (and otherwise empty) workspaces.  

Note also that there seems to be different behaviours (none working) when the exe has a different name spec'd on the Branding tab.

Finally, not all is lost as I have some situations in which this all works.  Problem is, there is no obvious difference between the setups.
Comment 1 Jeff McAffer CLA 2008-10-28 10:01:22 EDT
More info.  

In the end this manifests itself in an NPE in the native touchpoint while unzipping the erroneously empty artifact (see below).  Seems like we should protect against the NPE.  Of course, in this particular case that would have masked the real problem :-)

java.lang.NullPointerException
	at org.eclipse.equinox.internal.p2.touchpoint.natives.NativeTouchpoint.unzip(NativeTouchpoint.java:232)
	at org.eclipse.equinox.internal.p2.touchpoint.natives.NativeTouchpoint$2.execute(NativeTouchpoint.java:79)
	at org.eclipse.equinox.internal.p2.engine.ParameterizedProvisioningAction.execute(ParameterizedProvisioningAction.java:32)
	at org.eclipse.equinox.internal.provisional.p2.engine.Phase.mainPerform(Phase.java:122)
	at org.eclipse.equinox.internal.provisional.p2.engine.Phase.perform(Phase.java:79)
	at org.eclipse.equinox.internal.provisional.p2.engine.InstallableUnitPhase.perform(InstallableUnitPhase.java:53)
	at org.eclipse.equinox.internal.provisional.p2.engine.Phase.perform(Phase.java:46)
	at org.eclipse.equinox.internal.provisional.p2.engine.PhaseSet.perform(PhaseSet.java:38)

Also, I was able to get this to happen repeatedly using the following steps.

1) create a new plugin project and use the RCP mail demo template
2) in the resultant project, create a product definition for the mail demo product
3) for fun, change the Launcher Name entry on the Launching tab
4) save and click export.  When you export, check the "Generate Metadata" box.

Comment 2 Jeff McAffer CLA 2008-10-28 10:24:05 EDT
ok, so I updated to i1027 and the behaviour is much better (thanks!). There is a new issue:

- The binary launcher archive has config.ini and eclipse.ini files in it.  These should not be shipped as binary but rather built up from IU instructions.

I can't get the latest source to see if the possibility of an NPE as noted in comment 1 has been addressed.
Comment 3 Lars Vogel CLA 2018-12-03 09:12:48 EST
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.
Comment 4 Lars Vogel CLA 2018-12-03 09:14:04 EST
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.
Comment 5 Eclipse Genie CLA 2020-11-23 15:08:10 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 6 Eclipse Genie CLA 2022-11-14 11:41:23 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.