Community
Participate
Working Groups
In order to provide complete simple type editing support through the properties view we should provide an advanced tab. This tab will allow editing of advanced attributes like final and perhaps id. Alternatively, we could consider adding these to the general tab.
Created attachment 116051 [details] Patch A new advanced tab was created for the simpleType for the final attribute. The advanced tab was used due to consistency. Other components which have the final attribute use the advanced tab for modifying the final attribute. Id was not included, since this change would result in the need for Id to be added in many other components for consistency. This global change should be addressed in a separate bug in the future.
Created attachment 116447 [details] Refined Patch Refinements to previous patch: - corrected copyright header - XSDSimpleTypeAdvancedSection extends AbstractSection, since refactoring is not required - removed relayout(), since method is unused
Patch committed for 3.1M3.
Verified with I-3.1-20081031084005. Thanks Steven, while the patch is good in that it is consistent with how other similar properties are handled (final for elements, finalDefault, block default, etc) I don't think that the drop down widged is the most appropriate for the task. Using the combo only allows the user to pick one choice instead of what the schema specification allows which is one of #all | list of (list | union | restriction). Try typing "list union" as the value for the final attribute and see how the widget in the advanced tab behaves. In this case it seems we've again picked simplicity over completness. I think that for the future we probably need to think this through, pick the right UI widget for the task and make changes consistently. For example the UI for this could be a combination of two radio buttons and three checkboxes or something like that. Or at least a combo with the right combinations?
Closing. We'll open other bugs for additional changes.
