Bug 251693 - NamingConventions.suggestXXXNames should call suggestVariableNames()
Summary: NamingConventions.suggestXXXNames should call suggestVariableNames()
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M4   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-22 07:20 EDT by David Audel CLA
Modified: 2008-12-09 05:51 EST (History)
3 users (show)

See Also:

Attachments
Proposed fix (22.50 KB, patch)
2008-11-20 07:01 EST, David Audel CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Audel CLA 2008-10-22 07:20:33 EDT 
The old API NamingConventions.suggestXXXNames() should call the new API NamingConventions.suggestVariableNames().
Comment 1 David Audel CLA 2008-11-20 06:58:13 EST 
Other methods of NamingConventions should use new methods instead of deprecated methods.
Comment 2 David Audel CLA 2008-11-20 07:01:56 EST 
Created attachment 118352 [details]
Proposed fix
Comment 3 David Audel CLA 2008-11-20 07:03:38 EST 
Released for 3.5M4.

Tests added
  NamingConventionsTests#testSuggestGetterName009()
  NamingConventionsTests#testSuggestSetterName003()
Comment 4 Markus Keller CLA 2008-11-20 13:37:34 EST 
FYI: I just ran JDT/UI tests from 2 weeks ago (using the deprecated APIs) against HEAD of JDT/Core, and except for the expected changes from bug 38111 comment 12, everything stayed green :-).
Comment 5 Srikanth Sankaran CLA 2008-12-09 03:53:31 EST 
Verified for 3.5M4 using I20081208-1800 build