Bug 251245 - [editor] Failed to execute select all
Summary: [editor] Failed to execute select all
Status: NEW
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: wst.wsdl (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: Future   Edit
Assignee: Project Inbox CLA
QA Contact: Keith Chong CLA
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2008-10-17 11:08 EDT by Valentin Baciu CLA
Modified: 2010-07-20 11:36 EDT (History)
1 user (show)

See Also:


Attachments
Apply to org.eclipse.wst.wsdl.ui (6.36 KB, patch)
2009-01-27 17:32 EST, Keith Chong CLA
no flags Details | Diff
Stack with NPE on delete after select all. (3.62 KB, text/plain)
2009-01-27 23:50 EST, Valentin Baciu CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Valentin Baciu CLA 2008-10-17 11:08:07 EDT
In the WSDL editor's graphical hit Ctrl+A or select Edit->Select All
The action fails and the following is logged in the PDE log:

null
Error
Fri Oct 17 11:06:48 EDT 2008
Failed to execute item selectAll

Same issue is still present in WTP 3.1 M3.
Comment 1 Keith Chong CLA 2009-01-27 17:32:39 EST
Created attachment 123960 [details]
Apply to org.eclipse.wst.wsdl.ui
Comment 2 Keith Chong CLA 2009-01-27 17:34:08 EST
Can we target this fix for 3.1M5 ?
Comment 3 Valentin Baciu CLA 2009-01-27 23:48:42 EST
Keith, thank you for the patch but I think this needs a bit more thought. 

The implementation of the select all action in the proposed patch recursively adds all figures to the selection. I'm thinking this is too much - perhaps it should only select the top level objects?

One think I tried was to invoke delete after select all and got some NPEs. I'll attach a stack.
Comment 4 Valentin Baciu CLA 2009-01-27 23:50:06 EST
Created attachment 123994 [details]
Stack with NPE on delete after select all.
Comment 5 Valentin Baciu CLA 2009-01-27 23:55:11 EST
I just noticed that the cut/copy/paste don't really work in the design view either... :-(
Comment 6 Keith Chong CLA 2009-01-28 08:33:32 EST
Hi Valentin, that's what select all is supposed to do.  ;-)  Notice that in the XML Editor's design view, expand the tree and do a Select All.  The children are also selected. (The actions don't seem to work either.)

I was aware of this follow-on problem that you found and I've already opened a bug against the XSD Editor about this.  (I didn't open one yet for the WSDL Editor)

See:  https://bugs.eclipse.org/bugs/show_bug.cgi?id=262684

Note that in the schema editor's index view, it doesn't make sense to select the categories, because you shouldn't be allowed to delete them.   Anything else should be selected.  Also in the details view.  
Comment 7 Valentin Baciu CLA 2009-01-28 09:00:47 EST
The reason I thought selecting the top level objects should be enough  is because they aggregate all their content. Any action on a selection that includes a top level object- like cut/copy/paste/delete - would act on the top level object and implicitly/recursively on their contents. For example, if you select/delete a service, all its ports go away too.

It would be interesting to see if selecting only top level objects and deleting them still causes grief in the delete action.

I would think the error log message reported initially is more benign than the NPE during delete.