Community
Participate
Working Groups
In this patch we have improved SQL server support. Most notable improvements are in following places: - DDL generator - added or improved generation support for: tables, procedures, triggers, views, indexes, constraints. - Database definitions - updated keywords and datatypes for 2000 and 2005 and added 2008. - Added support for User Defined Types. This patch is based on the fork we started at https://sourceforge.net/projects/dtp-mssql/ and feel that it is now stable and polished enough to contribute back to eclipse community. Link to SVN browser http://dtp-mssql.svn.sourceforge.net/viewvc/dtp-mssql/tags/0.1-ECLIPSE-CONTRIB-20081009-1/
Created attachment 114693 [details] Patch to improve SQL Servers
Wow Ivar. That's a huge patch! Let me take a look, but if this is a great contribution (and I have no reason to think it's not!), we'll get it going through the IP process for contribution to Galileo.
Thanks :) We have used only code from eclipse, if that's a help for IP process. And of course if there are any questions with this patch, I'm glad to help :)
Ivar, I can apply the patch to everything but SQL2005RoutineLoader.java. Not sure what it's complaining about, but it doesn't like a chunk of the lines of code. Can you simply attach that updated .java file? Or regenerate based on the latest HEAD code in CVS?
Created attachment 114700 [details] SQL routine loader for the patch As I just came home and it would take some time to create the patch, I'll upload the .java file. I'll try and fix the patch sometime tomorrow or monday.
No worries. Next week is fine. Your patch + the Java file worked great. It's nice to be able to generate valid DDL from a SQL Server database! I'm going to continue to test a bit, but I'll definitely recommend that this be approved for IP and get applied for Galileo. Thanks for the help!
(Just to clarify, we will need another patch to point the IP folks at, since they want a single patch to review and may not accept a patch + a different attachment. We try to make things easier by doing a single patch attachment for them.) Once you deliver your new patch, I'll probably go in and add EPL code headers and comments to all the files where it's missing (it was missing before your patch, so I'm happy to fix that fact). What is the name of the company you work for Ivar, so I know who to tell the IP reviewers this came from?
Great :) This patch contains work from me, Anton Safonov and Ahti Kitsik. We are from Nexb http://www.nexb.com/corp/.
Created attachment 114939 [details] Fixed patch. Fixed the patch. Previous patch tried to apply https://bugs.eclipse.org/bugs/show_bug.cgi?id=239968 proposed patch again.
Pending IP approval, this will go into Galileo. I will update the files with EPL'd headers where necessary and start the IP process as soon as the Eclipse IP folks can handle the request (first week of November it looks like).
Created attachment 116867 [details] Final patch with updated EPL headers This is the final patch with updated EPL headers where needed.
Submitted to IP process as CQ 2799
Hey Ivar... When getting this through the IP process, I ran into a small snag. They need an Employer Consent form to continue doing the due diligence. Here's what I had from the IP folks: "... we will need Nexb to sign an Employer Consent for the three contributors as they are in their employ. Nexb does have membership with Eclipse but they have not furnished us with a Member Committer Agreement. Therefore, could you interface with one of the contributors and ask they they arrange for Nexb to sign an ECF for the contribution. The ECF is the same form we use for committers but we also use it for contributions as well. Here is the URL http://www.eclipse.org/legal/committer_process/employer_consent.pdf The same form can be used for all three contributors (just ensure they list all three)." Can you guys fill out the form and fax it back to Eclipse? --Fitz
All the forms are now sent and should be ok :)
Thanks Ivar! I'll wait and see what comes of that.
Approved and delivered fixes today CQ was http://dev.eclipse.org/ipzilla/show_bug.cgi?id=2799 Thanks for all the great work and your patience Ivar!
Great news :)
Guys, question. why did the patch comment out DOUBLE_PRECISION? <predefinedDataTypeDefinitions xmi:id="DOUBLE_PRECISION_1" keyConstraintSupported="true" multipleColumnsSupported="true" primitiveType="DOUBLE_PRECISION" jdbcEnumType="8" javaClassName="double">--> <!-- <defaultValueTypes>NULL</defaultValueTypes>--> <!-- <name>DOUBLE PRECISION</name>--> <!-- </predefinedDataTypeDefinitions>--> thanks, - Hemant
Good question. Ivar? Any thoughts? --Fitz
The reason is that SQL server doesn't have double precision, but there are float and real. http://msdn.microsoft.com/en-us/library/ms187752.aspx
i tried deploying to SQLServer 2005 a CREATE TABLE ddl in which one of the columns was of type DOUBLE PRECISION. The server created the table succesfully. Only the DOUBLE PRECISION column was converted by the server to FLOAT. but the server still accepted it in the ddl. based on above, i propose we add back to the vendor doc the DOUBLE PRECISION. the lack of it is breaking some of our implementations.
Ivar, any thoughts?
Sorry for taking so long. I'm not against adding this back, but I'd prefer staying with standards :) Hermant, can you create a patch, if not I can do it. As a sidenote: I'm not sure what would happen, if you run sql with DOUBLE PRECISION in MS SQL manager (unfortunately I can't check at the moment), but if these SQL statements are only for your application, then no harm will happen I suppose.
Hey Ivar... Hemant is on vacation until next month. Would you mind creating the patch?
Ok, I'll do it sometime this week.
I don't see this latest work being done in time for M6, so am bumping to M7.
Created attachment 129365 [details] Adds back double precision to xmi. Sorry for the huge delay.
No worries. Thanks Ivar! We'll get this into M7.
Hemant or Larry, can you take a look at this patch and make sure it does what we need it to do?
thx, Brian, Ivar. i will verify the patch. if ok, should i go ahead and apply it? for M7, would that be the HEAD branch?
Yes, HEAD please.
verified and applied patch "Adds back double precision to xmi" to HEAD (1.7 M7). tagged and released.
Thanks Hemant!
