Community
Participate
Working Groups
Created attachment 114618 [details] stack traces We are an Eclipse adopter. One of our users reported the following problem: When running an 'Organize Imports' on the Commerce workspace, the process will hang for a very long time. I've left it running for a couple of hours with not return and my only recourse was to kill the process. I've also noticed that occasionally my CPU utilization will be 100% but there are no jobs running in RAD. I've taken several thread dumps from these occasions and the results are the same. I've included the thread dumps in the defect. I've looked through the stack traces, they all have to do with JavaSearchScope org/eclipse/jdt/internal/core/search/JavaSearchScope.add(Bytecode PC:621(Compiled Code))
I'm not seeing a hang in the attached stack traces. The code is running normally. However there might be a performance problem. We would need more details to debug this problem: - the Eclipse build id - steps to reproduce the problem
*** Bug 251737 has been marked as a duplicate of this bug. ***
(In reply to comment #1) > I'm not seeing a hang in the attached stack traces. The code is running > normally. However there might be a performance problem. > > We would need more details to debug this problem: > - the Eclipse build id > - steps to reproduce the problem > Please provide requested info to help us to reproduce and fix, thanks
(In reply to comment #4) > (In reply to comment #1) > > I'm not seeing a hang in the attached stack traces. The code is running > > normally. However there might be a performance problem. > > > > We would need more details to debug this problem: > > - the Eclipse build id > > - steps to reproduce the problem > > > Please provide requested info to help us to reproduce and fix, thanks > For this defect I was passing along information from one of our users (Brian Lima who is on the CC list for this defect). For that problem they are using the version of our product that is built on Eclipse 3.4. For the new defect that I opened (Bug 251737), it was using a more current version of Eclipse 3.4.1.
Reproducing the issue is quite easy when using the full WebSphere Commerce workspace. Problem is this workspace is internal to IBM so only IBMers can work on it (maybe not so much an issue for this defect?). I've seen the problem when I run Organize Imports in the Java editor. It'll lock up the GUI with no way to cancel. Only way to stop is to kill the Java process.
This is a side effect of fix for bug 229951. Project may be removed from the projectsToBeAdded set and so may be added to the scope several times. As in this workspace, there are 166 projects with a huge and deep references tree, we're facing a dramatic performance issue :-(
*** Bug 252315 has been marked as a duplicate of this bug. ***
Created attachment 116274 [details] Proposed patch on top of 3.4.1 I will test this patch this afternoon onto the workspace of Gary's machine...
Jerome, is it OK to address this issue for 3.4.2?
+1 for 3.4.2 since this is a performance regression comparing to 3.3.x and the symptoms are pretty bad (it takes an infinite amount of time to complete)
Really good news, the fix works :-) I was able to perform any search request in the 'Commerce' workspace: it took only around 31ms to create the scope...
Created attachment 116511 [details] Proposed patch for R3_4_maintenance stream
Created attachment 116617 [details] Proposed patch for R3_4_maintenance branch Test has been improved in this new patch.
Released for 3.4.2 in R3_4_maintenance stream.
Created attachment 116633 [details] Proposed patch on HEAD stream
Released for 3.5M4 in HEAD stream.
*** Bug 254611 has been marked as a duplicate of this bug. ***
Verified for 3.5M4 using I20081209-0100
(In reply to comment #12) > Really good news, the fix works :-) I was able to perform any search request in > the 'Commerce' workspace: it took only around 31ms to create the scope... > Verified for 3.4.2 on Gary's machine
