Comment 1 David McKnight 2008-10-08 17:22:41 EDT

Created attachment 114607 [details]
patch for waiting for final timestamp

This patch is a straight back-port from what we have in HEAD.

Comment 2 David McKnight 2008-10-10 10:18:16 EDT

Created attachment 114795 [details]
updated patch to deal with compatibility issues with old IBM dstore server

Comment 3 David McKnight 2008-10-10 10:19:45 EDT

Created attachment 114796 [details]
updated patch to deal with compat issues with old IBM dstore server

Comment 4 David McKnight 2008-10-17 10:37:58 EDT

Created attachment 115398 [details]
updated patch to ensure original timestamp is the original

Comment 5 David McKnight 2008-10-17 10:53:20 EDT

Created attachment 115401 [details]
another update to let the wait method timeout

Comment 6 David McKnight 2008-10-17 11:36:45 EDT

Created attachment 115408 [details]
another update to also check that monitor isn't cancelled

Comment 7 David McKnight 2008-10-21 09:41:24 EDT

Created attachment 115693 [details]
patch dealing with remote file cache

Comment 8 David McKnight 2008-11-07 12:20:44 EST

Created attachment 117341 [details]
updated patch

Here's the updated backport patch.

Comment 9 Kevin Doyle 2008-11-07 16:32:53 EST

SystemUploadConflictAction.BackgroundSaveasJob.run()  

We do:

// copy temp file to remote system
                    fs.upload(_tempFile.getLocation().makeAbsolute().toOSString(), _remoteFile, SystemEncodingUtil.ENCODING_UTF_8, monitor);


why was this changed to _remoteFile instead of _saveasFile?

Otherwise code review seems okay.  Need to test it out after hearing about above.

Comment 10 David McKnight 2008-11-07 16:41:51 EST

Created attachment 117370 [details]
update to the SystemUploadConflictAction.BackgroundSaveAsJob

Adding this patch to ammend SystemUploadConflictAction.BackgroundSaveAsJob since we shouldn't be passing in _remoteFile (it should be _saveAsFile).

Comment 11 Kevin Doyle 2008-11-10 12:41:48 EST

Review +.

Comment 12 David McKnight 2008-11-10 14:18:49 EST

I've committed the changes to cvs.

Comment 13 David McKnight 2008-12-04 14:14:49 EST

(In reply to comment #12)
> I've committed the changes to cvs.
> 

updated to match the HEAD.