Bug 250129 - [repo] can RepositoryEvent provide repo flags?
Summary: [repo] can RepositoryEvent provide repo flags?
Status: RESOLVED WONTFIX
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords: api, performance
Depends on:
Blocks: 236485
  Show dependency tree
 
Reported: 2008-10-08 13:08 EDT by Susan McCourt CLA
Modified: 2020-02-20 05:58 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2008-10-08 13:08:32 EDT
while debugging yesterday I noticed the UI was getting 2, sometimes 3 repository add events when the user adds a repo.  I already ignore disabled repos, so I was a bit surprised.

What's happening is that any cache repos that are added are also triggering events.  Currently I can't tell via the event that what got added is a system repo vs. a user-visible repo.  It would be nice if I could.

The workaround in the UI would be to query the non-system repos every time I get an add event and then check the URLs against the location of the repository that was added, but I'm guessing the repo manager already has this info handy at the time the event is triggered.
Comment 1 Susan McCourt CLA 2008-10-14 18:06:25 EDT
> What's happening is that any cache repos that are added are also triggering
> events.  Currently I can't tell via the event that what got added is a system
> repo vs. a user-visible repo.  It would be nice if I could.

I decided to issue a special UI event when the user adds a repository in the course of fixing bug #248989.  So this is not as high a priority to me as it originally was.  I do think this is still generally useful, though, and should probably be visited during M4 while assessing bug #234213.
Comment 2 John Arthorne CLA 2008-10-15 09:31:22 EDT
Does this mean your views won't be updated if someone adds a repository programmatically? What about repository references that may get added implicitly when a repository is loaded?
Comment 3 Susan McCourt CLA 2008-10-15 12:16:41 EDT
(In reply to comment #2)
> Does this mean your views won't be updated if someone adds a repository
> programmatically? 
It means that the available IU view (as used in the install wizard and the PDE target provisioner) will only auto-load and highlight a repo that is added using ProvisioningUtil.  Other add events will be ignored.  This is the only view that auto-loads a repo that has been added by the user, so it's important that it can distinguish user-added repos from others.  Other views (the admin UI, the manage sites dialog, etc.) still respond to the core events.  

>What about repository references that may get added
> implicitly when a repository is loaded?
These are the ones I'm specifically wanting to ignore.  I don't want to respond to new references or system repos in that particular view...at least at this point in time.  Once we settle on whether our repo reference strategy needs to change or not (bug #234213) and whether this affects repo presentation, I may revisit this decision.  
Comment 4 John Arthorne CLA 2008-12-08 10:50:26 EST
Didn't make it for M4.
Comment 5 Eclipse Webmaster CLA 2019-09-06 16:04:21 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 6 Ed Merks CLA 2020-02-20 05:58:29 EST
This issue is stale.