Community
Participate
Working Groups
Build ID: 3.0.3 Steps To Reproduce: The current org.eclipse.wst.server.core.runtimeTypes extension point has the moduleTypes element that allows adopters to list the supported module types when defining a new runtime type. This API currently requires setting the full list of supported module types in the runtime type definition. If a new module type has been added, then the original runtime type definition needs to be modified in order to support the new module types. This bug is to request a new extension point to be added to allow adding new module type support to an existing runtime type outside of the runtimeTypes definition. More information:
Created attachment 115400 [details] v0.1 The following changes is not a complete fix but an initial proposal of the changes. The idea is to get review comments on the proposed changes, once finalized the code should contain NLS.messages, and more appropriate null check if any is required.
Some suggested changes on the existing patch: 1. Make the naming convention consistent to the existing extension points serverTypes and runtime Types, so the extension name "runtimeSupportedModuleType" should be used instead of "RuntimeSupportedModuleType". 2. Consider to accept wildcards on the runtime types, e.g. the user can use org.eclipse.tomcat.* for all tomcat servers.
Created attachment 115470 [details] v0.2 I think I found a better way of doing things, by reusing some of the code that was already there.
Created attachment 115471 [details] v0.2 I think I found a better way of doing things, by reusing some of the code that was already there.
Comment on attachment 115471 [details] v0.2 The network was slow.. and I got impatient and added the file twice :)
This new patch doesn't yet have the changes suggested in comment #2
Tim, any suggestion on the proposed patch?
Created attachment 115710 [details] v0.3 This new patch include the changes for comment #2, and the schema for the new extension point. Also better null checks.
Created attachment 116306 [details] v1.0 I have talked to Tim about this bug, and we agree that adding ModuleType to a Runtime sounds kind of odd, because currently there is no support for adding publish extension to a particular runtime. So perhaps we need to extend the publish mechanism as well.
Created attachment 116307 [details] v1.1 v1.0 of this patch contained some changes from a different bug, I have now cleaned that up and attached v1.1
Created attachment 116478 [details] v2.0 I found that v1.1 would not work in all situations. So I came up with a different approach.
This new enhancement support will be moved to 3.1
I am targeting this to 3.2 as we should decide if this is a good improvement or not and test the changes on the latest patch
The patch for this bug has been ready for a while. Changes committed to HEAD
This patch has been ready for a while, committing to HEAD
Changes released to 32 stream, which is currently HEAD
New Gerrit change created: https://git.eclipse.org/r/108881
