Bug 249320 - JJ: Launch Shell action not available in Remote System Details/Monitor views
Summary: JJ: Launch Shell action not available in Remote System Details/Monitor views
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M3   Edit
Assignee: Kevin Doyle CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on: 242431
Blocks:
  Show dependency tree
 
Reported: 2008-10-01 09:54 EDT by Kevin Doyle CLA
Modified: 2008-11-12 12:58 EST (History)
3 users (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2008-11-12 10:43 EST, Kevin Doyle CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Doyle CLA 2008-10-01 09:54:59 EDT 
The Launch Shell action is contributed to the Remote Systems view and as such doesn't show up in the Remote System Details or Monitor views.

Another reason we need Bug #242431.
Comment 1 Martin Oberhuber CLA 2008-10-01 10:18:41 EDT 
Just adding the menu item should be simple enough by copying some markup in the org.eclipse.rse.shells.ui/plugin.xml -- I don't think that this really depends on bug 242431.

The additional menu contributions should be made just by referencing the existing command, rather than duplicating it.

This should be simple enough for a BugDay bug.
Comment 2 Kevin Doyle CLA 2008-11-12 10:43:54 EST 
Created attachment 117670 [details]
Patch
Comment 3 Kevin Doyle CLA 2008-11-12 10:44:44 EST 
Committed fix.
Comment 4 Martin Oberhuber CLA 2008-11-12 12:58:24 EST 
For the records, I also changed the markup in rse.terminals.ui/plugin.xml:

        <menuContribution
              locationURI="popup:org.eclipse.rse.views.common?after=additions">

Any plugin which uses the new rse.views.common markup in order to contribute
its menu to all the RSE views needs to change its bundle dependency in the
MANIFEST.MF to say that it requires rse.ui version 3.1 at least: [3.1,4.0)