Bug 249066 - dependency analysis not primed for non-workspace plug-ins
Summary: dependency analysis not primed for non-workspace plug-ins
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.5 RC1   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
: 256282 262329 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-09-29 22:00 EDT by Jeff McAffer CLA
Modified: 2009-05-07 15:45 EDT (History)
4 users (show)

See Also:
darin.eclipse: review+


Attachments
Patch (1.59 KB, patch)
2009-04-29 03:17 EDT, Deepak Azad CLA
caniszczyk: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff McAffer CLA 2008-09-29 22:00:03 EDT
in m2

- open a plugin editor (mine was on a bundle from the target)
- on the Dependencies tab, expand the Dependency Analysis section
- click on the Show dependent plugins... link
- notice the Plugin Dependencies view opens 
- the problem is that in my system the view is empty.  
- right click and select Focus on...
- enter the name of the plugin you were editing
- notice that now the view has lots of great content

The ideal workflow would be if you are editing the Foo bundle and select "show dependencies", the view that opens would show the dependencies without further action.
Comment 1 Chris Aniszczyk CLA 2008-09-30 12:37:45 EDT
This only happens for non-workspace bundles.

Looking at a fix.
Comment 2 Deepak Azad CLA 2009-04-29 03:17:15 EDT
Created attachment 133696 [details]
Patch

Reason for the bug is that the code is looking for a project (getProject()), which is not there for non workspace bundles. Instead it should be looking for a plugin, as is done in doFindLoops() method of the same class.
Comment 3 Curtis Windatt CLA 2009-04-29 09:53:15 EDT
We can review this patch for RC1.
Comment 4 Chris Aniszczyk CLA 2009-04-30 15:15:56 EDT
*** Bug 262329 has been marked as a duplicate of this bug. ***
Comment 5 Darin Wright CLA 2009-05-06 09:21:48 EDT
*** Bug 256282 has been marked as a duplicate of this bug. ***
Comment 6 Chris Aniszczyk CLA 2009-05-07 15:03:02 EDT
done.

> 20090507

Thanks for the patch Deepak!
Comment 7 Darin Wright CLA 2009-05-07 15:33:48 EDT
Does not work for me. The view is empty. I see getPlugin().getId() returning null in this case. The plugin.xml editor does not seem to work at all for external bundles... all text fields are empty on the overview page, for example.
Comment 8 Darin Wright CLA 2009-05-07 15:34:06 EDT
Suggest to revert/defer.
Comment 9 Darin Wright CLA 2009-05-07 15:41:36 EDT
Works if you open the manifest editor from the Plugins view... if you open from the navigator, it does not... hmmm. OK.
Comment 10 Darin Wright CLA 2009-05-07 15:41:53 EDT
Verified.
Comment 11 Chris Aniszczyk CLA 2009-05-07 15:45:07 EDT
I see how it doesn't work now.

If you open it from the navigator and JUST have the plugin model loaded (ie., not the MANIFEST.MF in any of the tabs), it will fail.