Community
Participate
Working Groups
it would be great to have a preference in PDE to hide source bundles from all the various views. It is not clear where people need/want to see them in the launch config or the plugins view or ... An alternative would be to group them together under a different node in the view/dialog/list if possible.
Yes, there is a general work item for this on the 3.5 plan.
Bug for suppressing them in the import dialog is bug 242168.
This will be looked at after most of the target platform rework is done, marking as M6.
*** Bug 264100 has been marked as a duplicate of this bug. ***
Created attachment 125088 [details] org.eclipse.pde.ui.patch A quick stab at adding the ability to hide source bundles. This enables it for the plug-ins view and PDE-related launch configurations.
Created attachment 125147 [details] org.eclipse.pde.ui.patch An updated patch.
done. > 20090209 We added a new preference to show source bundles... it's off by default. Source bundles are currently hidden in the plug-ins view and all PDE-based launch configurations. There are still places we need to look at hiding source bundles, which I'll open another bug for.
Re-opening. I think the option is confusing in its current state. The current "Show source plug-ins" label/title doesn't let the user know where this will take effect. (Sure, we could add doc...) I wonder if it would be better to have options in specific views for this. For example, in the new target editor, we want to show source bundles so users see what source will be part of their target (for debugging purposes). This will conflict with the default setting. We plan to have a toggle filter on the plug-ins (content) veiwer to show/hide source. In general, it might be simpler to have individual settings rather than a global preference (it also makes it easier to change on the fly rather than having to go back to the preference page to change a global setting).
(In reply to comment #8) > In general, it might be simpler > to have individual settings rather than a global preference (it also makes it > easier to change on the fly rather than having to go back to the preference > page to change a global setting). > +1 for individual settings. This would allow us to set proper defaults based on what we are doing. For example, on the import dialog we would not show source by default, while in the target platform we would. Right now, the default setting is to not show source bundles which just removes things randomly from the UI with no information on how to turn it back on (for example, in the launch config if you have 100 bundles, it says you have 200 of 200 plug-ins selected).
-1 for individual settings because 99.9% of the time people don't want to see source bundles. The only case I can envision is if people are looking to see what source locations are available. We can discuss on the PDE call.
(In reply to comment #10) > The only case I can envision is if people are looking to see > what source locations are available. I agree this is the most common case. To me the issues are that the preference in its current form does not have enough information to let the user know what checking/unchecking will do, and that this setting will conflict/not work on the target wizard (which feels inconsistent). I agree we need ways to filter source bundles from the UI.
So we can improve the wording a bit. On the PDE call, we discussed modifying IPluginModelBase to have an isSourceBundle or something to make filtering easier. I haven't decided yet if this is the best way to do it yet.
my 2c. In cases where the user "wants source" they probably don't want to see the source bundles in the list. They just clutter things up. For example, in the target platform people typically want the source bundles included if they are there but it is pretty uninteresting to see them in the list (other than to perhaps confirm that they are indeed selected). In the launch or dependency scenarios source bundles are not relevant. Summary: if there are no cases for wanting to see the source bundles, why have an option in the view/dialog to show the source bundles? The global preference feels like a 'fail safe" option in case there is some scenario we are not seeing. In the target lists there might be an option to "include source bundles" or some such.
we will polish this off in M7
Marking fixed, as the preference is there and working. Will file new bugs as required.
