Bug 248852 - new plugin project from JAR includes .settings dir
Summary: new plugin project from JAR includes .settings dir
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-09-27 17:16 EDT by Jeff McAffer CLA
Modified: 2008-10-02 11:02 EDT (History)
3 users (show)

See Also:

Attachments
patch (1.89 KB, patch)
2008-09-28 08:34 EDT, Benjamin Cabé CLA 		caniszczyk: iplog+
Details | Diff
mylyn/context/zip (909 bytes, application/octet-stream)
2008-09-28 08:34 EDT, Benjamin Cabé CLA 		no flags Details
mylyn/context/zip (2.27 KB, application/octet-stream)
2008-09-29 15:11 EDT, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff McAffer CLA 2008-09-27 17:16:17 EDT 
in M2

after creating a new plugin project from an existing JAR file the build.properties includes .settings in the list of bin.includes files.  Not likely a desired behaviour.
Comment 1 Benjamin Cabé CLA 2008-09-28 08:18:03 EDT 
note that it only happens if the "unzip the JAR archives into the project" option is checked
Comment 2 Benjamin Cabé CLA 2008-09-28 08:34:02 EDT 
Created attachment 113680 [details]
patch

.settings is no more added to bin.includes
Comment 3 Benjamin Cabé CLA 2008-09-28 08:34:09 EDT 
Created attachment 113681 [details]
mylyn/context/zip
Comment 4 Chris Aniszczyk CLA 2008-09-28 14:18:46 EDT 
Thanks Ben!
Comment 5 Chris Aniszczyk CLA 2008-09-29 15:11:11 EDT 
Thanks again Ben!

I made some small changes to use constants from ICoreConstants when possible.

> 20090929
Comment 6 Chris Aniszczyk CLA 2008-09-29 15:11:14 EDT 
Created attachment 113795 [details]
mylyn/context/zip
Comment 7 Curtis Windatt CLA 2008-10-02 11:01:17 EDT 
Reopen to re-assign
Comment 8 Curtis Windatt CLA 2008-10-02 11:02:01 EDT 
Thanks for the patch Ben.