Bug 248519 - [ds tooling] Component Definition Information -- Fields should use SWT.BORDER style
Summary: [ds tooling] Component Definition Information -- Fields should use SWT.BORDER...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Simon Archer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-09-24 22:33 EDT by Simon Archer CLA
Modified: 2008-09-24 22:46 EDT (History)
1 user (show)

See Also:

Attachments
Screen shots (67.84 KB, image/png)
2008-09-24 22:33 EDT, Simon Archer CLA 		no flags Details
Patch (3.59 KB, patch)
2008-09-24 22:34 EDT, Simon Archer CLA 		caniszczyk: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Archer CLA 2008-09-24 22:33:27 EDT 
Created attachment 113431 [details]
Screen shots

Using Eclipse 3.5M2

The "Component Definition Information" group, as created by DSFileWizardPage.java, does NOT use the SWT.BORDER style for the Name and Class fields, which looks wrong along side other fields that do.  You might not see this on all windowing systems... I see it on Win XP running the Win2K skin. See the attached screen shot.

Not only is the SWT.BORDER style missing, but the layout is overly complicated and things don't quite line up right if you look carefully to the "decorated" versions of the screen shots.  Also, when I applied the SWT.BORDER style to the Text controls the lower edge of the Group was clipped.

Please see the attached patch that resolves these problems.  Thanks.
Comment 1 Simon Archer CLA 2008-09-24 22:34:17 EDT 
Created attachment 113432 [details]
Patch
Comment 2 Chris Aniszczyk CLA 2008-09-24 22:38:01 EDT 
done.

> 20090924

Thanks for your contribution :)
Comment 3 Simon Archer CLA 2008-09-24 22:46:08 EDT 
Thanks for accepting and applying the patch, Chris.