Bug 248267 - [mirror] Validate arguments
Summary: [mirror] Validate arguments
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Andrew Cattle CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 249309 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-09-23 09:51 EDT by Pascal Rapicault CLA
Modified: 2008-11-05 16:12 EST (History)
2 users (show)

See Also:

Attachments
Added functionality and tests (10.97 KB, patch)
2008-10-01 16:46 EDT, Andrew Cattle CLA 		dj.houghton: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2008-09-23 09:51:14 EDT 
The mirrroring application needs to validate the arguments that are being passed to it. For example, check  if there is a source and a target specified on the command line and also check if the source repository exist.
Comment 1 Andrew Cattle CLA 2008-09-23 16:02:14 EDT 
The Metadata MirrorApplication.java already does this. I'll see about adding similar code to the Artifact MirrorApplication
Comment 2 Andrew Cattle CLA 2008-10-01 10:52:18 EDT 
*** Bug 249309 has been marked as a duplicate of this bug. ***
Comment 3 Andrew Cattle CLA 2008-10-01 16:46:07 EDT 
Created attachment 114044 [details]
Added functionality and tests

Added Metadata's MirrorApplication's validation to Artifact's MirroringApplication.

Changed the expected type of exception for one of the existing ArtifactMirrorApplicationTest test cases (a result of validating the repositories)

Added test cases to both test suites to verify behaviour when not given repository locations.
Comment 4 DJ Houghton CLA 2008-10-02 17:08:29 EDT 
Released to HEAD.
Thanks.