Bug 248176 - Selected preset is not set if preset id has not changed
Summary: Selected preset is not set if preset id has not changed
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: Faceted Project Framework (show other bugs)
Version: 3.0.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0.3   Edit
Assignee: Jason Peterson CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-09-22 13:33 EDT by Jason Peterson CLA
Modified: 2008-10-07 12:45 EDT (History)
3 users (show)

See Also:
jasonpet: review? (konstantin)
cbridgha: review+

Attachments
patch (1.42 KB, patch)
2008-09-22 13:33 EDT, Jason Peterson CLA 		bjorn.freeman-benson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Peterson CLA 2008-09-22 13:33:29 EDT 
Created attachment 113167 [details]
patch

FacetedProjectWorkingCopy.setSelectedPreset( final String presetId ) is not working in an adopter product when I change the target runtime from <WAS 70> to <None> since both have a default configuration with a preset ID of default.configuration.  As a result, the project facets are not reset for the default configuration for <None> and it is using the project facets for the <WAS 70> default configuration.

To fix this I have attached a patch where I also check if the project facets of the new selected preset are equal to the facets of the previous preset.
Comment 1 Chuck Bridgham CLA 2008-09-28 16:48:38 EDT 
Patch looks safe enough.. Kosta what do you think?
Comment 2 Konstantin Komissarchik CLA 2008-09-29 15:44:18 EDT 
I was out at Oracle OpenWorld all of last week. Still trying to catch up. I will review this patch in the next couple of days at the latest.
Comment 3 Jason Peterson CLA 2008-10-06 15:04:03 EDT 
Have you looked at this yet Kosta?  Need to get this in soon.
Comment 4 Konstantin Komissarchik CLA 2008-10-07 12:45:00 EDT 
Looks good. I do not see any potential problems. Thanks for the patch. Released the patch into 3.0.3 and 3.1 code streams.