Bug 248152 - Delay loading tracing option files unless tracing is actually used
Summary: Delay loading tracing option files unless tracing is actually used
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2008-09-22 11:29 EDT by Chris Aniszczyk CLA
Modified: 2008-12-17 11:09 EST (History)
2 users (show)

See Also:
caniszczyk: pmc_approved? (jeffmcaffer)
caniszczyk: review? (darin.eclipse)

Attachments
org.eclipse.pde.ui.patch (1.22 KB, patch)
2008-09-22 11:31 EDT, Chris Aniszczyk CLA 		no flags Details | Diff
mylyn/context/zip (805 bytes, application/octet-stream)
2008-09-22 11:31 EDT, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2008-09-22 11:29:09 EDT 
+++ This bug was initially created as a clone of Bug #229073 +++

In the launch configuration dialog, opening a runtime workbench configuration or a junit plug-in test configuration, there is a significant pause (5 seconds or more).  This makes even small changes to a configuration an annoying experience.

One problem with this is that the tracing options get loaded as soon as a PDE-based launch configuration is used. This can take forever if you have a lot of plug-ins that we need to break apart for the .options file. A solution here is to simply delay querying for the .option files until we need them (ie., the user selects the tracing tab)
Comment 1 Chris Aniszczyk CLA 2008-09-22 11:31:48 EDT 
Created attachment 113137 [details]
org.eclipse.pde.ui.patch

Simply delay the loading of .options files until the tab is selected.
Comment 2 Chris Aniszczyk CLA 2008-09-22 11:31:51 EDT 
Created attachment 113138 [details]
mylyn/context/zip
Comment 3 Chris Aniszczyk CLA 2008-09-22 11:32:36 EDT 
committed to HEAD.

> 20090922

Leaving open for considering in 3.4.2 as a simple fix for an annoying performance issue.
Comment 4 Chris Aniszczyk CLA 2008-10-02 17:38:37 EDT 
Darin, thoughts for 3.4.2?

This has been a performance problem for people in the past. This patch is already in HEAD and is relatively safe.
Comment 5 Darin Wright CLA 2008-10-03 10:04:29 EDT 
Currently, this has introduced another bug:

* Select an Eclipse Application config in the launch dialog
* Activate the tracing tab
* Select another Eclipse Application config

> The tracing tab is now blank since it was not activated
Comment 6 Chris Aniszczyk CLA 2008-12-17 11:09:30 EST 
This isn't critical for 3.4.2 and we had a fix go in for 3.5 that works.