Bug 247959 - Problem while importing projects without devices on workspace
Summary: Problem while importing projects without devices on workspace
Status: CLOSED FIXED
Alias: None
Product: MTJ (Archived)
Classification: Tools
Component: Core (show other bugs)
Version: 0.9   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.9   Edit
Assignee: Diego Madruga Sandin CLA
QA Contact:
URL:
Whiteboard:
Keywords: core
Depends on:
Blocks:
 
Reported: 2008-09-19 08:29 EDT by Edwin Carlo Ribeiro Marinho CLA
Modified: 2008-10-15 09:24 EDT (History)
3 users (show)

See Also:


Attachments
JavaMEClasspathContainerInitializer fixes (7.96 KB, patch)
2008-09-19 15:06 EDT, Diego Madruga Sandin CLA
no flags Details | Diff
JavaMEClasspathContainerInitializer fixes V2 (81.88 KB, patch)
2008-09-22 18:05 EDT, Diego Madruga Sandin CLA
no flags Details | Diff
error markes in project (39.46 KB, image/png)
2008-09-22 18:06 EDT, Diego Madruga Sandin CLA
no flags Details
Quick fix option for "No device definition is associated to this project." marker (22.30 KB, image/png)
2008-09-22 18:08 EDT, Diego Madruga Sandin CLA
no flags Details
project preference page (55.04 KB, image/png)
2008-09-22 18:09 EDT, Diego Madruga Sandin CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Edwin Carlo Ribeiro Marinho CLA 2008-09-19 08:29:20 EDT
MTJ 0.9M1 Testing
Installation : eclipse-SDK-3.4.0 (I20080617-2000) 
MTJ install  : mtj-runtime
java.runtime : Java(TM) SE Runtime Environment (build 1.6.0_07-b06)
os.name:     : Windows XP Professional, Service Pack 3


Overview: 

    Problem while importing projects without devices on workspace

Steps to Reproduce: 

    1) Try to import many projects without the device on the workspace

Actual Results: 

    Some projects are not imported (do not appear on the package explorer) and the error (additional information) is present on the error log

Expected Results:

    Import the projects without problem.

Build Date & Platform:

    Build id: 200808291424 / Windows XP

Additional Builds and Platforms: 

    ...

Additional Information:

    ERROR on Error Log
java.lang.NullPointerException
at org.eclipse.mtj.core.internal.JavaMEClasspathContainer.<init>(JavaMEClasspathContainer.java:53)
at org.eclipse.mtj.core.internal.JavaMEClasspathContainerInitializer.initialize(JavaMEClasspathContainerInitializer.java:66)
at org.eclipse.jdt.internal.core.JavaModelManager.initializeContainer(JavaModelManager.java:2220)
at org.eclipse.jdt.internal.core.JavaModelManager.getClasspathContainer(JavaModelManager.java:1546)
at org.eclipse.jdt.core.JavaCore.getClasspathContainer(JavaCore.java:1571)
at org.eclipse.jdt.internal.core.JavaProject.resolveClasspath(JavaProject.java:2558)
at org.eclipse.jdt.internal.core.JavaProject.getResolvedClasspath(JavaProject.java:1848)
at org.eclipse.jdt.internal.core.JavaProject.computeExpandedClasspath(JavaProject.java:449)
at org.eclipse.jdt.internal.core.JavaProject.getExpandedClasspath(JavaProject.java:1453)
at org.eclipse.jdt.internal.core.builder.NameEnvironment.computeClasspathLocations(NameEnvironment.java:93)
at org.eclipse.jdt.internal.core.builder.NameEnvironment.<init>(NameEnvironment.java:41)
at org.eclipse.jdt.internal.core.builder.JavaBuilder.initializeBuilder(JavaBuilder.java:590)
at org.eclipse.jdt.internal.core.builder.JavaBuilder.build(JavaBuilder.java:166)
at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:624)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:166)
at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:197)
at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:246)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:249)
at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:302)
at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:334)
at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:137)
at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:235)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
Comment 1 Diego Madruga Sandin CLA 2008-09-19 15:06:50 EDT
Created attachment 113041 [details]
JavaMEClasspathContainerInitializer fixes

I found that the problem was in the JavaMEClasspathContainerInitializer.

The method : public void initialize(IPath containerPath, IJavaProject project)

uses an instance of device, but didn't check if the instance was null.

I'm attaching a patch that fix this issue.
Comment 2 Diego Madruga Sandin CLA 2008-09-22 18:05:45 EDT
Created attachment 113199 [details]
JavaMEClasspathContainerInitializer fixes V2

New version of the patch.

The behavior is:

1) import the project;
2) set the JavaMEClasspathContainer to null
3) add a marker to the project to inform that the JavaMEClasspathContainer could not be resolved
3) add a marker to the project to inform that there is no device associated to it

I also added a quick fix to the missing device marker that will open the projects property page where the user can import a device to the project.

I'm also including some screen shots that shows this behavior.
Comment 3 Diego Madruga Sandin CLA 2008-09-22 18:06:50 EDT
Created attachment 113200 [details]
error markes in project
Comment 4 Diego Madruga Sandin CLA 2008-09-22 18:08:21 EDT
Created attachment 113201 [details]
Quick fix option for  "No device definition is associated to this project." marker
Comment 5 Diego Madruga Sandin CLA 2008-09-22 18:09:09 EDT
Created attachment 113202 [details]
project preference page
Comment 6 Hugo Raniere CLA 2008-09-23 09:55:50 EDT
I've tested the patch on comment #2 and it is working fine for me.

I'm voting +1 to include this fix in 0.9 release
Comment 7 Gustavo de Paula CLA 2008-09-23 12:58:42 EDT
also tested new patch and i'm ok to commit it

(In reply to comment #6)
> I've tested the patch on comment #2 and it is working fine for me.
> 
> I'm voting +1 to include this fix in 0.9 release
> 

Comment 8 Diego Madruga Sandin CLA 2008-09-24 10:22:44 EDT
Fixed
Comment 9 Gustavo de Paula CLA 2008-10-15 09:24:09 EDT
all bugs we integrated and release on MTj 0.9