Bug 247889 - MirrorApplication does not handle "-append" arguement consistently
Summary: MirrorApplication does not handle "-append" arguement consistently
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Andrew Cattle CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-09-18 16:23 EDT by Andrew Cattle CLA
Modified: 2008-11-05 16:09 EST (History)
2 users (show)

See Also:

Attachments
Added code to handle "-append" arguement (1.66 KB, patch)
2008-09-22 13:40 EDT, Andrew Cattle CLA 		dj.houghton: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Cattle CLA 2008-09-18 16:23:38 EDT 
The version of MirrorApplication for metadata repositories and the version for artifact repositories treat the "-append" flags inconsistently.

By default the artifact repository version will delete all preexisting artifacts before mirroring unless the "-append" argument is found.

By contrast, the metadata repository version appends the metadata by default. The metadata version doesn't even look for the "-append" argument.

See bug 247214 for more information.
Comment 1 Andrew Cattle CLA 2008-09-22 13:40:49 EDT 
Created attachment 113168 [details]
Added code to handle "-append" arguement

Code is pretty much taken straight from the artifact.repository MirrorApplication.java

I ran the patch through my metadata test cases and they all passed.
Comment 2 DJ Houghton CLA 2008-09-30 11:00:10 EDT 
Released to HEAD with minor changes including making the artifact repo mirroring  consistent as well.