Bug 247795 - [POLISH] Remove TransientContents list from CDOResourceImpl
Summary: [POLISH] Remove TransientContents list from CDOResourceImpl
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: M3   Edit
Assignee: Simon Mc Duff CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on: 247794
Blocks:
  Show dependency tree
 
Reported: 2008-09-18 03:48 EDT by Eike Stepper CLA
Modified: 2010-06-29 09:21 EDT (History)
1 user (show)

See Also:
stepper: galileo+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Stepper CLA 2008-09-18 03:48:58 EDT
blocked by bug #247794
Comment 1 Simon Mc Duff CLA 2008-09-18 07:39:16 EDT
It will be hard to replace PersistentContent since it derived from CDOStoreEList<Object>. Isn't 

Comment 2 Eike Stepper CLA 2008-09-18 07:50:37 EDT
Of course!
Comment 3 Simon Mc Duff CLA 2008-11-01 11:55:48 EDT
Committed to HEAD 
Included when fixing problem:
251544: Instance of list are not the same for the following transition transient/new persisted/transient resulting strange behavior (NPE)
https://bugs.eclipse.org/bugs/show_bug.cgi?id=251544
Comment 4 Eike Stepper CLA 2008-11-04 17:02:47 EST
Fix available in CDO 2.0.0 I200811041537
Comment 5 Eike Stepper CLA 2009-01-06 06:13:29 EST
Hi Simon,

I tried to evaluate Ed's patch. While it was looking good, I had the feeling that we don't need it anymore (due to refactoring of CDOObjectImpl and CDOResourceImpl). When you have time could you please clarify this?
Comment 6 Simon Mc Duff CLA 2009-01-06 08:14:29 EST
(In reply to comment #5)
> Hi Simon,
> 
> I tried to evaluate Ed's patch. While it was looking good, I had the feeling
> that we don't need it anymore (due to refactoring of CDOObjectImpl and
> CDOResourceImpl). When you have time could you please clarify this?
> 

Your feeling is right.

Since we do not distinguish between Transient and persistent anymore we will not be able to use it. Our ContentsCDOList class extends BasicEStoreEList, I don't see how it will be possible to use it.


Simon
Comment 7 Eike Stepper CLA 2009-06-27 11:53:08 EDT
Generally available.