Comment 1 Chris Aniszczyk 2008-09-17 11:05:29 EDT

I'm trying to fix this now but don't have CVS access from the meeting. Here is what needs to be done.

Comment 2 Chris Aniszczyk 2008-09-17 11:05:53 EDT

	public Image getImage(Object obj) {
		if (obj instanceof IDSObject) {
			return getObjectImage((IDSObject) obj);
		}

		// TODO consider changing this
		if (obj instanceof IFormPage)
			return PDEPlugin.getDefault().getLabelProvider().get(
					PDEPluginImages.DESC_PAGE_OBJ);

		return super.getImage(obj);
	}

	public String getText(Object obj) {

		if (obj instanceof IDSObject) {
			return getObjectText((IDSObject) obj);
		}

		if (obj instanceof IFormPage)
			return ((IFormPage) obj).getTitle();

		return super.getText(obj);
	}

Comment 3 Chris Aniszczyk 2008-09-17 11:06:26 EDT

I recommend putting this patch in for M2 if you can Curtis.

I won't have access to CVS (stupid firewalls)

Comment 4 Chris Aniszczyk 2008-09-17 11:06:58 EDT

oh, we basically just need to be cognizant of the IFormPage in the label provider

Comment 5 Curtis Windatt 2008-09-17 13:03:33 EDT

Created attachment 112793 [details]
Patch

It appears that I do not have commit rights to the DS tooling bundles, might have to wait until M3 :)

Comment 6 Curtis Windatt 2008-09-17 13:05:53 EDT

Rafael, if you have been given commit rights and have the time, please commit the patch.

Comment 7 Chris Aniszczyk 2008-09-17 13:06:45 EDT

I'll have time this evening before the last build.

Comment 8 Chris Aniszczyk 2008-09-17 20:26:18 EDT

done.

> 20080917

Comment 9 Chris Aniszczyk 2008-09-17 20:26:30 EDT

Created attachment 112847 [details]
mylyn/context/zip