Bug 247573 - [api] IClassifierConstants.TYPE_LINK == "link" is not in sync with actual usage of "symbolic link" in the code
Summary: [api] IClassifierConstants.TYPE_LINK == "link" is not in sync with actual usa...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.1 M4   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on: 141823
Blocks:
  Show dependency tree
 
Reported: 2008-09-16 17:27 EDT by Martin Oberhuber CLA
Modified: 2008-11-17 18:49 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2008-09-16 17:27:24 EDT 
From bug 141823 comment 2: RSE uses the String "symbolic link" everywhere in the code as classification String for symbolic link. But IClassifierConstants.TYPE_LINK is specified as the String "link".

This is not consistent. Either TYPE_LINK denotes something different than symbolic links, then we should add a constant TYPE_SYMBOLIC_LINK to the API and reference it everywhere; 

or, we specify TYPE_LINK to denote any kind of link whereas TYPE_SYMBOLIC_LINK is for symbolic links specifically; then clients such as RemoteFile and RSEFileStore should use a Regex pattern like "[a-z ]*link" in order to identify files classified as "any kind of link".

In either case, intended usage of TYPE_LINK should be documented.
Comment 1 Martin Oberhuber CLA 2008-09-16 17:30:11 EDT 
Dave what do you think about this?
Comment 2 David McKnight CLA 2008-11-17 14:50:44 EST 
(In reply to comment #1)
> Dave what do you think about this?
> 

Right now I don't know of anything that references IClassifierConstants.TYPE_LINK.  I suspect that this was intended for symbolic links since, at least for dstore, there is a classification for "symbolic link" but not for "link".  I think at one point (pre-open source) the type we used to denote a "symbolic link" was just "link".  I'm thinking of adding TYPE_SYMBOLIC_LINK and deprecating TYPE_LINK.
Comment 3 Martin Oberhuber CLA 2008-11-17 14:59:22 EST 
Sounds good to me.
Comment 4 David McKnight CLA 2008-11-17 18:49:38 EST 
I've committed the change to cvs.