Bug 247546 - New project wizard issue on ganymede
Summary: New project wizard issue on ganymede
Status: CLOSED FIXED
Alias: None
Product: MTJ (Archived)
Classification: Tools
Component: UI (show other bugs)
Version: 0.9   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.9   Edit
Assignee: Diego Madruga Sandin CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility, ui, usability
Depends on:
Blocks:
 
Reported: 2008-09-16 15:11 EDT by Gustavo de Paula CLA
Modified: 2008-10-15 09:24 EDT (History)
4 users (show)

See Also:
wds057: documentation+


Attachments
new project dialog (247.63 KB, image/bmp)
2008-09-17 09:43 EDT, Gustavo de Paula CLA
no flags Details
first wizard page (39.87 KB, image/png)
2008-09-18 14:58 EDT, Diego Madruga Sandin CLA
no flags Details
Second wizard page (44.95 KB, image/png)
2008-09-18 14:58 EDT, Diego Madruga Sandin CLA
no flags Details
project wizard patch (170.01 KB, patch)
2008-09-18 14:59 EDT, Diego Madruga Sandin CLA
no flags Details | Diff
error log (1.71 KB, application/octet-stream)
2008-09-19 15:29 EDT, Hugo Raniere CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo de Paula CLA 2008-09-16 15:11:39 EDT
on ganymede the new midlet project wizard shows an error message. it is necessary to update the project wizard to fix that
Comment 1 Craig Setera CLA 2008-09-17 08:40:48 EDT
What is the error message?  I've not seen an error message on this wizard.  Can you make sure to put more details in the bug reports so others can follow along?
Comment 2 Gustavo de Paula CLA 2008-09-17 09:43:09 EDT
Created attachment 112762 [details]
new project dialog

hi craig,

in the dialog to create a project is shows a warning and the folders src and res are marked with error. it seems that we need to create the folders before creating the project itself (thats how jdt does).

there is no impact in the project creation flow. if the user, confirms, cancel, etc., everything will work fine. it is not breaking any functionality, so i'm not totally convinced that we should fix that. 

on the other hand, this is a wizard that all users will go through, maybe it make sense to remove the warning + error. this would probably increase the user quality perception.

this only happens on ganymede.

comments???

:)
gep
Comment 3 Gang(Allen) Ma CLA 2008-09-18 07:33:23 EDT
I think there may be three choices to fix it:

1.create the project when user see the page, and remove it when user choose "back" or "cancel"(just like JDT).

2.find some way to make sure the error message will not show(just like it is in eclipse 3.3).

3.remove the last page, user can configure the build path in the project property page.

I think the second choice is better, but I'm not sure whether it can be done, the code is a little complicated.
Comment 4 Craig Setera CLA 2008-09-18 07:37:46 EDT
Given that we are quickly approaching the release, I would vote for the simplest solution.  In my mind #3 is the simplest solution.  The others have quite a few risks associated with the implementatation.
Comment 5 Diego Madruga Sandin CLA 2008-09-18 14:58:09 EDT
Created attachment 112941 [details]
first wizard page
Comment 6 Diego Madruga Sandin CLA 2008-09-18 14:58:41 EDT
Created attachment 112942 [details]
Second wizard page
Comment 7 Diego Madruga Sandin CLA 2008-09-18 14:59:01 EDT
Created attachment 112943 [details]
project wizard patch
Comment 8 Diego Madruga Sandin CLA 2008-09-18 14:59:49 EDT
I did some work on the project wizard, and its working the same way as the JDT wizard.

I'm attaching a couple of screen shots and a patch with this modification. Could anyone test it out?
Comment 9 Feng(Marvin) Wang CLA 2008-09-18 23:03:21 EDT
I tried out this patch. It work really well. 

(In reply to comment #8)
> I did some work on the project wizard, and its working the same way as the JDT
> wizard.
> 
> I'm attaching a couple of screen shots and a patch with this modification.
> Could anyone test it out?
> 

Comment 10 Gang(Allen) Ma CLA 2008-09-18 23:57:06 EDT
I also tested it, it works fine.

(In reply to comment #8)
> I did some work on the project wizard, and its working the same way as the JDT
> wizard.
> I'm attaching a couple of screen shots and a patch with this modification.
> Could anyone test it out?

Comment 11 Hugo Raniere CLA 2008-09-19 09:24:57 EDT
Hi All, 

I tested the patch on comment #7 and it worked fine for me as well. For me it's a good solution and can be integrated in MTJ mainline.

In my opinion, the first screen is a bit cluttered (especially if we consider that more widgets will be added later - see bug 245896) but I am OK with it as this kind of screen is becoming a standard in Eclipse projects such as JDT and others.
Comment 12 Hugo Raniere CLA 2008-09-19 11:57:21 EDT
I've just found a bug in the patch.

Steps to reproduce:
1. Open the new midlet wizard
2. Fill a name for the project
3. Press finish

Behavior found: the project is created but the wizard is not closed.

Expected behavior: the project wizard must be closed.
Comment 13 Diego Madruga Sandin CLA 2008-09-19 13:09:43 EDT
Hi Hugo, 

I couldn't reproduce the behavior you described.

My steps:
  1) Imported WTK
  2) Opened the project wizard and filled the project name field.
  3) Pressed finish

Behavior found:
  The project was correctly created in the workspace, the wizard page closed, and the jad editor was displayed.

I'm using: 

SDK version: eclipse-SDK-3.4.0 (I20080617-2000) 
java.runtime : Java(TM) SE Runtime Environment (build 1.6.0_07-b06)
os.name:     : Windows XP Professional, Service Pack 3

Could you give me more details in the error? Maybe console logs or stack trace.

Thanks.
Diego

(In reply to comment #12)
> I've just found a bug in the patch.
> 
> Steps to reproduce:
> 1. Open the new midlet wizard
> 2. Fill a name for the project
> 3. Press finish
> 
> Behavior found: the project is created but the wizard is not closed.
> 
> Expected behavior: the project wizard must be closed.
> 

Comment 14 Hugo Raniere CLA 2008-09-19 15:29:18 EDT
Created attachment 113042 [details]
error log

Hi Diego, 

I'm using a very similar environment:
SDK version: eclipse-SDK-3.4.0 (I20080617-2000) 
java.runtime : Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_11-b03)
os.name:     : Windows XP Professional, Service Pack 2

I looked int the Error log view and there was an error in org.eclipse.mtj.core plugin with another nested error from org.eclipse.core.runtime. Both erros have no messages, but there is a stack trace.

attached is the .log contents.

Latter I will try to test more to see if I find the root cause here.
Comment 15 Gustavo de Paula CLA 2008-09-19 16:13:45 EDT
are you albe to always reproduce the issue? until now no one saw the same problem and it seems that you saw it with the very basic project creation steps

(In reply to comment #14)
> Created an attachment (id=113042) [details]
> error log
> 
> Hi Diego, 
> 
> I'm using a very similar environment:
> SDK version: eclipse-SDK-3.4.0 (I20080617-2000) 
> java.runtime : Java(TM) 2 Runtime Environment, Standard Edition (build
> 1.5.0_11-b03)
> os.name:     : Windows XP Professional, Service Pack 2
> 
> I looked int the Error log view and there was an error in org.eclipse.mtj.core
> plugin with another nested error from org.eclipse.core.runtime. Both erros have
> no messages, but there is a stack trace.
> 
> attached is the .log contents.
> 
> Latter I will try to test more to see if I find the root cause here.
> 

Comment 16 Hugo Raniere CLA 2008-09-20 15:54:17 EDT
Hi Gustavo and Diego, 

I did some other tests here and the problem is related to my workspace. If I use a clean workspace, the problem doesn't occur, so I think there is something wrong with my original workspace. I'll take a deeper look into it to verify if it is really an MTJ issue, but at first I think there is nothing to worry about.



(In reply to comment #15)
> are you albe to always reproduce the issue? until now no one saw the same
> problem and it seems that you saw it with the very basic project creation steps
> 
> (In reply to comment #14)
> > Created an attachment (id=113042) [details] [details]
> > error log
> > 
> > Hi Diego, 
> > 
> > I'm using a very similar environment:
> > SDK version: eclipse-SDK-3.4.0 (I20080617-2000) 
> > java.runtime : Java(TM) 2 Runtime Environment, Standard Edition (build
> > 1.5.0_11-b03)
> > os.name:     : Windows XP Professional, Service Pack 2
> > 
> > I looked int the Error log view and there was an error in org.eclipse.mtj.core
> > plugin with another nested error from org.eclipse.core.runtime. Both erros have
> > no messages, but there is a stack trace.
> > 
> > attached is the .log contents.
> > 
> > Latter I will try to test more to see if I find the root cause here.
> > 
> 

Comment 17 Diego Madruga Sandin CLA 2008-09-22 12:22:38 EDT
I'll commit this path today, and this fix will be available in tomorrow NB (N20080923) 
Comment 18 Diego Madruga Sandin CLA 2008-09-22 13:32:34 EDT
Checked in the code and updated the User documentation.
Comment 19 Hugo Raniere CLA 2008-09-22 18:42:58 EDT
Hi Diego,

After more tests I confirmed the bug described on comment #12. I've figured out that in the workspace I was using, I've changed the JDT preferences to no create src and bin folders separately and use project root as src instead (preferences > Java > Build Path).

Can you also change this preference and confirm if you can reproduce this bug?
Comment 20 Diego Madruga Sandin CLA 2008-09-23 15:02:19 EDT
Hi Hugo,

I could reproduce the behavior you found and committed a fix to it.


(In reply to comment #19)
> Hi Diego,
> 
> After more tests I confirmed the bug described on comment #12. I've figured out
> that in the workspace I was using, I've changed the JDT preferences to no
> create src and bin folders separately and use project root as src instead
> (preferences > Java > Build Path).
> 
> Can you also change this preference and confirm if you can reproduce this bug?
> 

Comment 21 Gustavo de Paula CLA 2008-10-15 09:24:03 EDT
all bugs we integrated and release on MTj 0.9