Bug 24744 - TODO: Task not found if comment after last closing brace
Summary: TODO: Task not found if comment after last closing brace
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1 M3   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 23096
Blocks:
  Show dependency tree
 
Reported: 2002-10-14 07:21 EDT by Jerome Lanneluc CLA
Modified: 2002-11-13 06:16 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2002-10-14 07:21:26 EDT 
Build 20021009

1. Add an extra marker task: 'TODO:'
2. Create the following cu:
public class A {
}
// TODO: something
3. Build
Observe: no task is created on this cu
Comment 1 Olivier Thomann CLA 2002-10-21 09:21:17 EDT 
The last line comment needs to be closed with a line break. Otherwise the
scanner should reject it and report an unterminated comment. See bug 23096.
It is easy to fix the scanner, but the complete fix (which would include the
following line break has part of the line comment) breaks the code formatter. So
until we don't have the new formatter ready, I cannot release 23096.
If the line comment is properly closed, it is easy to add the TODO: detection.
Comment 2 Olivier Thomann CLA 2002-10-21 09:45:11 EDT 
In fact if the line comment ends with a line break, there is nothing to change.
Do we want to be able to report TODO: tasks inside line comments which are not
properly closed?
Comment 3 Olivier Thomann CLA 2002-10-21 09:58:57 EDT 
To be consistent, we should check this kind of "invalid line comments" until bug
23096 is fixed.
Comment 4 Olivier Thomann CLA 2002-10-22 14:51:27 EDT 
Fixed and released in 2.1 stream.
Regression tests added.
Comment 5 David Audel CLA 2002-11-13 06:16:05 EST 
Verified.