Bug 247362 - [commands] -thread-info parsing not consistent with existing API
Summary: [commands] -thread-info parsing not consistent with existing API
Status: CLOSED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 0 DD 1.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: DD 1.1   Edit
Assignee: Marc Khouzam CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2008-09-15 18:07 EDT by Pawel Piech CLA
Modified: 2014-01-29 22:07 EST (History)
2 users (show)

See Also:
cdtdoug: iplog-

Attachments
Patch with proposed changes. (18.76 KB, patch)
2008-09-15 18:07 EDT, Pawel Piech CLA 		cdtdoug: iplog-
Details | Diff
Fix for typo (1.04 KB, patch)
2008-09-18 22:48 EDT, Marc Khouzam CLA 		cdtdoug: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Piech CLA 2008-09-15 18:07:03 EDT 
Created attachment 112605 [details]
Patch with proposed changes.

While looking through new APIs I noticed that the way MIThreadInfoInfo parses MI output is somewhat different than existing precedent.

There are IThreadInfo and IThreadFrame interfaces, where as interfaces are not used for other commands and IMO they're not really necessary here.  Also ThreadFrame appears to be a duplicate of the existing MIFrame.

In the attached patch I refactored this code slightly to make it match the existing pattern.  I didn't attach a patch yet, please comment.
Comment 1 Pawel Piech CLA 2008-09-18 18:38:44 EDT 
I checked in the changes.  Marc, please review.
Comment 2 Marc Khouzam CLA 2008-09-18 22:48:17 EDT 
Created attachment 112980 [details]
Fix for typo

(In reply to comment #1)
> I checked in the changes.  Marc, please review.

I knew there was a bug I was supposed to look at but I just couldn't remember which one.  Sorry for the delay.

So, the changes look good and they are cleaner.  Thanks for doing this.
One little type that slipped in (maybe with eclipse's copy/paste that doesn't seem to work 100%) is fixed by this patch which I committed.

Verified.
Comment 3 Pawel Piech CLA 2008-09-19 00:19:49 EDT 
(In reply to comment #2)
Oops, thank you.
Comment 4 Pawel Piech CLA 2009-01-07 15:52:52 EST 
DD 1.1 reelased!