Bug 246788 - "PDE Tools > Externalize Strings" dialog does not detect all non-externalized attributes/values of the <extension-point> and <extension> elements
Summary: "PDE Tools > Externalize Strings" dialog does not detect all non-externalized...
Status: RESOLVED DUPLICATE of bug 252329
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2008-09-09 16:49 EDT by Simon Archer CLA
Modified: 2008-11-04 17:58 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Archer CLA 2008-09-09 16:49:37 EDT
The "PDE Tools > Externalize Strings" dialog does not detect all non-externalized attributes/values of the <extension-point> and <extension> elements. Consider the following fictional example:

  <extension-point
    id="suggestions"
    name="Suggestions Box"
    schema="schema/suggestions.exsd"/>

  <extension point="org.example.suggestions" name="My Suggestion">
    <suggestion>Turn up the air conditioning</suggestion>
  </extension>

In this case the following non-externalized strings should have been identified by the wizard:

1. The <extension-point> element's required name attribute.
2. The <extension> element's optional name attribute. 
3. The <suggestion> element's contents.

Regarding the <suggestion> element's contents, I am not even sure how to say in the EXSD schema editor that the contents is translatable.  This could well be a separate bug.

If you have the PDE preferences cranked up you can get warnings and quick fixes in the Plug-in Manifest Editor for 1 and 2 above.  But not for 3.  The quick fixes are as follows:

1. Externalize the name attribute
2. Open Externalize Strings Wizard...

Of these two, the first works well, but the second does not open the wizard but rather responds with a dialog that says: "All strings in manifest file have been externalized".  Clearly there is conflicting logic here.

This bug report has become quite long and I'm sorry for presenting so many issues, but they all seem to be related.

For references, here something from the Eclipse 3.3 documentation regarding these elements:

http://help.eclipse.org/help33/index.jsp?topic=/org.eclipse.platform.doc.isv/reference/misc/plugin_manifest.html

A candidate for bugday perhaps.
Comment 1 Benjamin Cabé CLA 2008-11-04 17:54:24 EST
This is a duplicate of bug 252329, fixed a few days ago

(In reply to comment #0)
> [...]
> 3. The <suggestion> element's contents.
> 
> Regarding the <suggestion> element's contents, I am not even sure how to say in
> the EXSD schema editor that the contents is translatable.  This could well be a
> separate bug.

I think it is a separate bug, indeed
Comment 2 Chris Aniszczyk CLA 2008-11-04 17:58:18 EST
Thanks Benjamin!

*** This bug has been marked as a duplicate of bug 252329 ***