Bug 246730 - "Restore Defaults" button does not update the combo on "Symbol Set Definitions" screen
Summary: "Restore Defaults" button does not update the combo on "Symbol Set Definition...
Status: CLOSED FIXED
Alias: None
Product: MTJ (Archived)
Classification: Tools
Component: UI (show other bugs)
Version: 0.9   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.9   Edit
Assignee: Hugo Raniere CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility, ui, usability
Depends on:
Blocks:
 
Reported: 2008-09-09 10:38 EDT by Edwin Carlo Ribeiro Marinho CLA
Modified: 2008-10-15 09:23 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Edwin Carlo Ribeiro Marinho CLA 2008-09-09 10:38:04 EDT 
MTJ 0.9M1 Testing
Installation : eclipse-SDK-3.4.0 (I20080617-2000) 
MTJ install  : mtj-runtime
java.runtime : Java(TM) SE Runtime Environment (build 1.6.0_07-b06)
os.name:     : Windows XP Professional, Service Pack 3


Overview: 

    The "Restore Defaults" button does not update the combo on "Symbol Set Definitions" screen.

Steps to Reproduce: 

    1) Open the preferences (Window > Preferences)

    2) On the "Mobile Tools for Java" select the "Symbol Set Definitions"

    3) Press the "Remove" button to remove any "Definition Set"

    4) Press the "Restore Defaults" button

Actual Results: 

    The combo box is not updated

Expected Results:

    The combo box should show the device removed.

Build Date & Platform:

    eclipse-SDK-3.4.0 (I20080617-2000) on Windows XP

Additional Builds and Platforms: 

    ...

Additional Information:

    ...
Comment 1 Diego Madruga Sandin CLA 2008-09-09 20:52:04 EDT 
I believe this follows the same idea of Bug#: 244541 

From my perspective, there are no default values for the "Symbol Set
Definitions". I think it would be better to  remove the "Restore Defaults" button.

Does any one has other ideas?
Comment 2 Hugo Raniere CLA 2008-09-11 09:45:23 EDT 
Hi Diego,

As MTJ is now creating an initial Symbol set for each imported device, why not restore this initial set (for the device selected on the combo box) when the user press "Restore Default" button.
Comment 3 Diego Madruga Sandin CLA 2008-09-11 15:08:57 EDT 
(In reply to comment #2)
> Hi Diego,
> 
> As MTJ is now creating an initial Symbol set for each imported device, why not
> restore this initial set (for the device selected on the combo box) when the
> user press "Restore Default" button.
> 

It works if the Symbol set was created based on the device info, but if the selected Symbol set was created all by the user, what would be the expected behavior?
Comment 4 Hugo Raniere CLA 2008-09-12 10:24:12 EDT 
Hi Diego,

My initial thought was to remove any "user-created" symbol leaving only the auto-generated symbol list while importing devices. However, after more thoughts, I realized that this auto-generated list is not always created (the user has the ability to not create it while importing devices) it will make no sense to restore to this initial list if the user didn't select to create it.

By that, I'm changing my opinion and agreeing with you to remove this button.

+1 to remove "Restore Defaults" and "Apply" buttons.
Comment 5 Craig Setera CLA 2008-09-14 12:50:51 EDT 
+1 to remove
Comment 6 Gang(Allen) Ma CLA 2008-09-15 21:29:37 EDT 
+1 to remove
Comment 7 Hugo Raniere CLA 2008-09-17 08:13:43 EDT 
Hi all, 

as we already have 4 +1 to remove (couting with diego, that proposed the removal) and that is the majority of active committers, I'm going to remove these buttons.
Comment 8 Hugo Raniere CLA 2008-09-17 08:30:17 EDT 
'Restore Defaults' and 'Apply' buttons removed.
Comment 9 Gustavo de Paula CLA 2008-10-15 09:23:56 EDT 
all bugs we integrated and release on MTj 0.9