Bug 246281 - [plan] incremental compilation when changing annotations on a type can fail
Summary: [plan] incremental compilation when changing annotations on a type can fail
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.6.2   Edit
Assignee: aspectj inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-04 16:30 EDT by Andrew Clement CLA
Modified: 2008-09-04 17:06 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Clement CLA 2008-09-04 16:30:56 EDT 
If a pointcut conditionally advises some type based on an annotation being on a supertype in its hierarchy then AspectJ will fail to undo the weave if the super type has the annotation removed and an incremental compilation is performed.  The code in AjState that checks what constitutes a structure change doesn't take annotations into account and because it can affect this situation, it should.
Comment 1 Andrew Clement CLA 2008-09-04 17:06:21 EDT 
MultiProjectIncremental test added and fix committed.  The fix is a little lazy in that changing the order of two annotations will be considered a serious change, but that doesn't happen very often so I don't believe is worth checking for.

More serious is that it may not consider the change to an annotation value a structural change - but I can't write a testcase where that leads to problems...