Bug 246273 - BuildConfig seems to be under optimized
Summary: BuildConfig seems to be under optimized
Status: ASSIGNED
Alias: None
Product: AJDT
Classification: Tools
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P5 normal (vote)
Target Milestone: ---   Edit
Assignee: AJDT-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-04 15:50 EDT by Andrew Eisenberg CLA
Modified: 2008-12-14 11:51 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Eisenberg CLA 2008-09-04 15:50:20 EDT
The class BuidlConfig in ajdt.core seems to have a very inefficient way of constructing the list of included source files.  Also, why are the source files returned as a list, wouldn't a set be better?

I notice that the AJBuilder is traversing this list multiple times.  This list could potentially be large (includes every single source file in the project).

I don't know what kind of performance impact this actually has, and I should test it out before doing any premature optimizations.
Comment 1 Andrew Eisenberg CLA 2008-09-04 15:53:39 EDT
After doing a little bit of testing on my own, it seems that this is not a big problem.  I tested on a medium sized project (ajdt.core itself) by timing the loop that creates the included source files list as well as traverses it multiple times.

The result is 3 miliseconds spent doing it.  So, this is not worth my time to optimize.