Bug 245830 - ClasspathEntry illegally instantiates AssertionFailedException
Summary: ClasspathEntry illegally instantiates AssertionFailedException
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M2   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-01 04:46 EDT by Jerome Lanneluc CLA
Modified: 2008-09-15 09:58 EDT (History)
1 user (show)

See Also:

Attachments
Proposed fix (15.61 KB, patch)
2008-09-01 04:52 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2008-09-01 04:46:44 EDT 
I20080827-0935

PDE/Tools reports the following warning:

Description	Resource	Path	Location	Type
ClasspathEntry illegally instantiates AssertionFailedException	ClasspathEntry.java	org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core	line 775	API Usage Problem
Comment 1 Jerome Lanneluc CLA 2008-09-01 04:52:56 EDT 
Created attachment 111385 [details]
Proposed fix

Fix consists in defining ClasspathEntry.AssertionFailedException and throwing this exception instead of the runtime one. As a consequence this improves the message reported in the markers (it removes: "assertion failed: " before the message). Thus updated tests accprdingly.
Comment 2 Jerome Lanneluc CLA 2008-09-01 04:54:30 EDT 
Fix and updated tests released for 3.5M2
Comment 3 Olivier Thomann CLA 2008-09-15 09:58:18 EDT 
Verified for 3.5M2 using I20080914-2000