Bug 245699 - API breakage reported if removing extends of internal class
Summary: API breakage reported if removing extends of internal class
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M2   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 245835 245858 245860
  Show dependency tree
 
Reported: 2008-08-29 10:29 EDT by Jerome Lanneluc CLA
Modified: 2008-09-17 14:34 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2008-08-29 10:29:35 EDT 
I20080827-0935

Attempting to fix a problem where a public class extends an internal class (i.e. by removing the extends), API Tools now reports an API breakage saying that the superclass has changed.

Shouldn't it allow this "breakage" since it it fixing an invalid extends usage?
Comment 1 Olivier Thomann CLA 2008-09-04 14:50:24 EDT 
If the extended type is not API, it should not be considered as API breakage to remove it.
If the internal type is exposing public methods, then breaking changes to one of these methods will also be reported as a breaking change even if its declaring type is internal.
Comment 2 Olivier Thomann CLA 2008-09-12 19:13:59 EDT 
This is fixed in HEAD since we don't include internal types anymore inside class hierarchies.
Added regression test org.eclipse.pde.api.tools.comparator.tests.ClassDeltaTests#test137
Comment 3 Darin Wright CLA 2008-09-17 14:34:18 EDT 
Verified that removing an internal superclass does not report an error for change in superclass, bug filed bug 247703.