Community
Participate
Working Groups
Build ID: M20080221-1800 Steps To Reproduce: Today the "C/C++ General" property page is shown for objects that are INSTANCES of IProject, IFolder, ... This property page should also be shown for objects that ADAPT to IProject, IFolder, ... (this is actually the way the other property pages are defined). My use case is: I have my own view in which I show objects that adapt to IProject. For these objects, the "C/C++ General" page is not shown (but the other CDT property pages are shown). More information:
Hi, is there any plan to fix this? I think this is quite a light fix to make, and this would prevent us from patching CDT with each release. I cannot see why the enablement rule for the "C/C++ General" page should be different from the other property pages defines in org.eclipse.cdt.ui. Thanks in advance.
(In reply to comment #1) > Hi, is there any plan to fix this? I think this is quite a light fix to make, > and this would prevent us from patching CDT with each release. Sounds like you got the fix already. Would you share? It might help to get this task moving. > I cannot see why the enablement rule for the "C/C++ General" page should be > different from the other property pages defines in org.eclipse.cdt.ui. > Thanks in advance.
Created attachment 148895 [details] Patch The problem was the following: the property pages inside the "C/C++ General" category are displayed on objects that ADAPT to IProject (Documentation, File Types, Indexer, ...). But, on the other hand, the "C/C++ General" page itself is displayed for objects that are INSTANCES of IProject. Therefore, for objects that ADAPT to IProject but are not INSTANCES of IProject, those property pages are displayed but not grouped inside the "C/C++ General" category. This patch fixes this problem.
Sounds reasonable. But before I commit I would need to test the patch. Could you propose how to test your patch?
Created attachment 148968 [details] Project with both C and Java nature Here's a way to reproduce the issue: - Import the attached project (it has both the C and the Java nature) - Open the "Projects" view of the "Java Browsing" category - From this view, open the project properties -> You can see that the "C/C++ General" property page does not appear. On the other hand, when using the patch, it works.
Could you enter your real name in bugzilla so I could properly attribute your contribution to you?
(In reply to comment #6) > Could you enter your real name in bugzilla so I could properly attribute your > contribution to you? Done!
(In reply to comment #5) > Created an attachment (id=148968) > Project with both C and Java nature The example is helpful. This is real messy indeed. Committed the fix on HEAD (6.1) and 6.0.2. Thanks for the patch!
