Bug 245324 - Default extension (.xml) is supplemented whenever the file name is set in XML Wizard.
Summary: Default extension (.xml) is supplemented whenever the file name is set in XML...
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xml (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.2 M7   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords: needinfo
Depends on:
Blocks:
 
Reported: 2008-08-26 22:35 EDT by Mukoujima Daisuke CLA
Modified: 2010-04-05 15:07 EDT (History)
4 users (show)

See Also:
nsand.dev: review+

Attachments
patch for 245324 (1.09 KB, patch)
2008-08-27 01:44 EDT, Mukoujima Daisuke CLA 		nsand.dev: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mukoujima Daisuke CLA 2008-08-26 22:35:23 EDT 
Build ID: I20080617-2000

Steps To Reproduce:
1. The abc.xml.xml file exists.
2. The abc.xml file cannot be made.


More information:
Comment 1 Mukoujima Daisuke CLA 2008-08-27 01:44:20 EDT 
Created attachment 111027 [details]
patch for 245324
Comment 2 Nitin Dahyabhai CLA 2008-09-04 22:43:46 EDT 
I'm not having a problem creating abc.xml when abc.xml.xml exists, or the other way around.  Are there more steps?
Comment 3 Mukoujima Daisuke CLA 2008-09-16 21:22:33 EDT 
A detailed procedure is described.

1. The [New XML file] wizard makes "NewFile.xml.xml" for "example" folder.
2. The [New XML file] wizard selects "example" folder, and it is input to "File Name:" input field as "NewFile.xml". (It is "NewFile.xml" in default.)
3. The [Finish] button cannot be pushed.
4. If the value of "File Name:" input field is "NewFile", the [Finish] button can be pushed.
Comment 4 David Carver CLA 2009-03-19 17:19:32 EDT 
I have been able to reproduce this issue.

The exact steps are as follows.

1. Create a new XML file called "NewFile.xml.xml"
2. Use the New XML file wizard, and try the create a new file called "NewFile.xml".   You get the error marker, and can not advance on.

This appears that the file check is not doing a complete check.  I'll take a look at the patch and see if it is still applies cleanly and if it works.
Comment 5 David Carver CLA 2009-03-19 17:47:48 EDT 
The patch looks okay.  Mukoujima, I would make a couple of suggestions.

1. It contains your name in the Contributor header, along with the bug number.

2. Can you include a unit test for the patch?  I've figured out a way to write a unit test but it will take a small refactoring to make it testable.

I'm tentatively targeting this for 3.1M7, it's a fairly low risk patch.  Nitin please feel free to change the target.
Comment 6 Ian Tewksbury CLA 2010-03-04 16:56:04 EST 
This is still reproducible in WTP 3.2.  The given patch (which surprisingly enough the patch still applies cleanly after all this time) also seems to fix the problem.
Comment 7 Nick Sandonato CLA 2010-04-05 15:07:12 EDT 
Thanks for the patch. I've released to HEAD.