Bug 245313 - [view model] AbstractVMAdapter.getVMProviderIterable() is not thread-safe.
Summary: [view model] AbstractVMAdapter.getVMProviderIterable() is not thread-safe.
Status: CLOSED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 0 DD 1.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: DD 1.1   Edit
Assignee: Anton Leherbauer CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2008-08-26 17:46 EDT by Pawel Piech CLA
Modified: 2009-05-26 21:31 EDT (History)
2 users (show)

See Also:
cdtdoug: iplog-

Attachments
Javadoc fix and api filter (2.38 KB, patch)
2008-10-31 03:42 EDT, Anton Leherbauer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Piech CLA 2008-08-26 17:46:47 EDT 
This method which was added to AbstractVMAdapter to support synchronized event handling.  However, this method returns a reference to a collection which is accessed on multiple threads.  

Instead of returning an iterable getVMProviderIterable() should return an array which is a copy of the current vm providers.
Comment 1 Pawel Piech CLA 2008-10-30 13:53:42 EDT 
This bug was fixed with the changes for bug 251452.  Toni, please confirm.
Comment 2 Anton Leherbauer CLA 2008-10-31 03:42:53 EDT 
Created attachment 116591 [details]
Javadoc fix and api filter

I fixed some stale javadoc and spelling error.
Furthermore, I added an API filter to hide the breakage against 1.1M3.
Comment 3 Anton Leherbauer CLA 2008-10-31 03:44:26 EDT 
Verified.
Comment 4 Pawel Piech CLA 2009-01-07 16:06:31 EST 
DD 1.1 reelased!