Bug 245198 - [dstore] ServerLauncherProperties not restored
Summary: [dstore] ServerLauncherProperties not restored
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: 3.1 M3   Edit
Assignee: David Dykstal CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 252019
  Show dependency tree
 
Reported: 2008-08-25 21:33 EDT by Masao Nishimoto CLA
Modified: 2008-11-07 14:40 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Masao Nishimoto CLA 2008-08-25 21:33:03 EDT
This is from 243128.

RSEDOMImporter.restoreConnectorService() has the following logic:

  for (all children of connector service node) {
    restore subsystem;
    if (subsystem != null && service == null) {           ... (A)
       get service associated with the subsystem;         ... (B)
       if (service != null) {
          if (configuration supports server launcher properties) {
             create server_launcher;
             if (server_launcher != null) {
               get server launcher properties;            ... (C)
               ..

If the first subsystem has service but does not have server launcher, the service is filled at the line (B), but (C) is not executed.  For other subsystems, since service is already filled, condition at the line (A) is not satisfied, and (C) is never executed, even if the subsystem has server launcher.
Comment 1 David Dykstal CLA 2008-08-25 21:47:42 EDT
Thanks. I will look at this this week.
Comment 2 David McKnight CLA 2008-10-24 12:26:42 EDT
To fix this we need to make sure to check whether the server launcher properties have been restored - if not, then try to restore them for the next subsystem configurations until it has been restored. 

I've committed the fix for this and opened the backport, bug 252019.
Comment 3 David McKnight CLA 2008-11-07 14:40:38 EST
The fix was committed earlier.