Bug 245142 - There is no "Export Feature with AspectJ support" option
Summary: There is no "Export Feature with AspectJ support" option
Status: RESOLVED FIXED
Alias: None
Product: AJDT
Classification: Tools
Component: Core (show other bugs)
Version: 1.6.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2.0.1   Edit
Assignee: AJDT-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-25 12:06 EDT by Andrew Eisenberg CLA
Modified: 2009-10-06 23:53 EDT (History)
1 user (show)

See Also:

Attachments
AJFeature enabler (8.24 KB, patch)
2009-09-14 09:19 EDT, Felix Velasco CLA 		andrew.eisenberg: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Eisenberg CLA 2008-08-25 12:06:28 EDT 
There is no option to export features with AspectJ support.  When exporting featues in the standard way, the aspectj compiler is not invoked and so plugins are not compiled properly during the export.

It is a matter of invoking AJModelBuildScriptGenerator instead of ModelBuildScriptGenerator.

So far, no one has asked for this feature.  So this is low priority unless I get some interest in this.
Comment 1 Felix Velasco CLA 2009-09-14 04:44:56 EDT 
I'm (heavily) affected by this bug. Nowadays we have to generate all of our aspect aware plugins twice, once to properly create the feature, and then once again to get the code to work. The second time we export the plugins individually, of course.
This bug is preventing wide adoption of aspects in our platform, as we have over 300 plugins grouped in half a dozen features. Right now we only apply aspects in one of our smallest features, with just a dozen plugins.
Comment 2 Felix Velasco CLA 2009-09-14 09:19:26 EDT 
Created attachment 147098 [details]
AJFeature enabler

I decided to give it a try, and it was fairly easy to add support for exporting features. I'm attaching a patch that provides it.
It's missing the necessary plugin.xml and plugin.properties modifications, since I don't really know against which cvs branch should I make that patch. Locally I'm patching AJDT 2.0 for eclipse 3.4
Comment 3 Andrew Eisenberg CLA 2009-09-17 13:22:34 EDT 
Thanks for the patch.  I will have to test this out a bit, but eyeballing the code and it looks fairly reasonable.  I will be able to make the plugin.xml and other changes.

Initially, I will place this patch in the 3.5 branch and backport to 3.4 at a later date (for the 2.0.1 release).
Comment 4 Andrew Eisenberg CLA 2009-09-17 23:46:01 EDT 
I applied your patch.  It seems that things are not as simple as I would have hoped.  The export code for AJDT has not really been updated since eclipse 3.4.  In order to work with many of the new 3.5 options (eg- binary cycles and install directly into platform), I had to make quite a few changes.

Now, exporting a feature with AspectJ support is available and should work for you.  However, I have not yet been able to export source bundles or generate p2 metadata.  Please try this out and let me know if this works for you.
Comment 5 Andrew Eisenberg CLA 2009-09-30 14:36:51 EDT 
Move to the 2.0.2 release.
Comment 6 Andrew Eisenberg CLA 2009-10-06 23:53:45 EDT 
Mistake...this bug has been implemented and the feature is fully available for 2.0.1 in the .5 stream only.