Bug 245069 - [dstore] dstoreTrace has no timestamp
Summary: [dstore] dstoreTrace has no timestamp
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0.1   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-08-24 21:55 EDT by Noriaki Takatsu CLA
Modified: 2008-09-10 21:55 EDT (History)
2 users (show)

See Also:
mober.at+eclipse: pmc_approved+
kjdoyle: review+

Attachments
dstoreTrace should have timestamps (1.36 KB, patch)
2008-08-26 01:24 EDT, Noriaki Takatsu CLA 		dmcknigh: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noriaki Takatsu CLA 2008-08-24 21:55:52 EDT 
dstoreMemLogging has timestamp but dstoreTrace has no timestamp.
dstoreTrace should have timestamp, too.
Comment 1 Martin Oberhuber CLA 2008-08-25 05:28:18 EDT 
Would that require a protocol or API change?
Comment 2 Noriaki Takatsu CLA 2008-08-26 01:24:14 EDT 
Created attachment 110891 [details]
dstoreTrace should have timestamps

There is no need for any API change and timestamp should be added on each line 
of dstoreTrace just like memLogging.
Comment 3 David McKnight CLA 2008-09-10 10:02:06 EDT 
Martin, is it still possible to commit this for 3.0.1?
Comment 4 Kevin Doyle CLA 2008-09-10 20:07:13 EDT 
Simple enough.  + from me.
Comment 5 David McKnight CLA 2008-09-10 20:51:20 EDT 
I've committed this. Hopefully it can make it into the 3.0.1 build.
Comment 6 Martin Oberhuber CLA 2008-09-10 21:34:37 EDT 
I'm not against this change, but wouldn't it be better to have finer resolution for the timestamp? The Date class prints only seconds. I've personally mostly been using System.currentTimeMillis() to get finer resolution.

Also, please add the "contributed" kwd on the bug and "iplog+" kwd on the patch.
Comment 7 Noriaki Takatsu CLA 2008-09-10 21:46:11 EDT 
Legal Message:
 I, {Noriaki Takatsu}, declare that I developed attached code from scratch, 
 without referencing any 3rd party materials except material licensed under 
 the EPL. 
 I am authorized by my employer to make this contribution under the EPL.
Comment 8 Martin Oberhuber CLA 2008-09-10 21:55:22 EDT 
Released for 3.0.1