Bug 244541 - The "Restore Defaults" button does not work on device management screen
Summary: The "Restore Defaults" button does not work on device management screen
Status: CLOSED FIXED
Alias: None
Product: MTJ (Archived)
Classification: Tools
Component: UI (show other bugs)
Version: 0.9   Edit
Hardware: PC Linux
: P4 minor (vote)
Target Milestone: 0.9   Edit
Assignee: Hugo Raniere CLA
QA Contact:
URL:
Whiteboard:
Keywords: ui, usability
Depends on:
Blocks:
 
Reported: 2008-08-19 09:27 EDT by Edwin Carlo Ribeiro Marinho CLA
Modified: 2008-10-15 09:24 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Edwin Carlo Ribeiro Marinho CLA 2008-08-19 09:27:57 EDT
Build ID: M20080221-1800

Steps To Reproduce:
1. Open the Preferences (Window > Preferences...)
2. Select "Device Management" option inside "Mobile Tools for Java" tree on
the left pane
3. Import and/or remove some devices
4. Press "Restore Defaults" button

The table should refresh and show the previous devices, but the devices imported are visible and the removed are not visible on the table.


More information:
If press the "Ok" button the devices will continue the same that were before these actions.
Comment 1 Hugo Raniere CLA 2008-08-25 10:59:12 EDT
Hi Guys, 

I was discussing with Diego what should be the CORRECT behavior of the "Restore Defaults" button on the "Device Management" preference page. 

Our understanding differs from Edwin's one. We think it should not go to previous state (refresh and show the previous devices), instead, it should clean the device base, as this is the default.

However we are wondering if this button (together with the apply button) make sense to this screen, or can be disabled/removed. If they make sense, I think their behavior is not correct and we have to discuss/fix it.

What are your opinions on that matter?
Comment 2 Gang(Allen) Ma CLA 2008-08-29 01:09:32 EDT
I think this button may be removed, because there are no default values for the devices.

(In reply to comment #1)
> Hi Guys, 
> I was discussing with Diego what should be the CORRECT behavior of the "Restore
> Defaults" button on the "Device Management" preference page. 
> Our understanding differs from Edwin's one. We think it should not go to
> previous state (refresh and show the previous devices), instead, it should
> clean the device base, as this is the default.
> However we are wondering if this button (together with the apply button) make
> sense to this screen, or can be disabled/removed. If they make sense, I think
> their behavior is not correct and we have to discuss/fix it.
> What are your opinions on that matter?

Comment 3 Feng(Marvin) Wang CLA 2008-08-29 01:32:04 EDT
I think clean the device base is not a good idea. User may delete all the devices which thay take a good effort to add/edit by misoperation. User can always delete devices by the "delete" button.

So I think remove or disable the "Restore Defaults" button makes more sense.

(In reply to comment #1)
> Hi Guys, 
> 
> I was discussing with Diego what should be the CORRECT behavior of the "Restore
> Defaults" button on the "Device Management" preference page. 
> 
> Our understanding differs from Edwin's one. We think it should not go to
> previous state (refresh and show the previous devices), instead, it should
> clean the device base, as this is the default.
> 
> However we are wondering if this button (together with the apply button) make
> sense to this screen, or can be disabled/removed. If they make sense, I think
> their behavior is not correct and we have to discuss/fix it.
> 
> What are your opinions on that matter?
> 

Comment 4 Diego Madruga Sandin CLA 2008-08-29 08:00:17 EDT
I agree, since there are no default values, the "Restore Defaults" button should be left disabled. But I don't know if it is possible to disable it, since eclipse add the Restore and apply buttons by default. We'll have to investigate.
Comment 5 Hugo Raniere CLA 2008-08-29 09:54:15 EDT
Note that the apply/cancel/ok scheme is not working as expected as weel, as every change in the devices is automatically applied. If this scheme was in place and the user removed every device by misoperation, he should press cancel and get all devices back.

I don't think implementing this behavior worths, so I'm +1 to remove/disable "restore defaults" AND "apply" buttons if possible, but I'm open to discussions.
Comment 6 Craig Setera CLA 2008-08-29 10:00:34 EDT
+1 
Comment 7 Diego Madruga Sandin CLA 2008-08-29 10:21:38 EDT
I agree. 

+1 to remove or disable the restore and apply buttons
Comment 8 Gustavo de Paula CLA 2008-08-30 14:59:56 EDT
+1 ro remove the buttons
Comment 9 Hugo Raniere CLA 2008-09-02 19:56:25 EDT
"Restore Defaults" and "Apply" buttons removed per discussion.
Comment 10 Gustavo de Paula CLA 2008-10-15 09:24:23 EDT
all bugs we integrated and release on MTj 0.9