Bug 244444 - [performance] always reloading XHTML DTDs slows down processing of many files
Summary: [performance] always reloading XHTML DTDs slows down processing of many files
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.html (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P1 major (vote)
Target Milestone: 3.0.2   Edit
Assignee: Nitin Dahyabhai CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks: 245063
  Show dependency tree
 
Reported: 2008-08-18 12:24 EDT by Nitin Dahyabhai CLA
Modified: 2008-08-24 21:26 EDT (History)
3 users (show)

See Also:

Attachments
proposed patch (4.50 KB, patch)
2008-08-18 12:32 EDT, Nitin Dahyabhai CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nitin Dahyabhai CLA 2008-08-18 12:24:51 EDT 
When importing one of our internal large workspaces, the build time and processing involved was taking quite a long time.  One project contained roughly 1600 XHTML JSP files, and it was found that the repeated loading the XHTML DTDs was taking up the bulk of the time.
Comment 1 Nitin Dahyabhai CLA 2008-08-18 12:32:11 EDT 
Created attachment 110247 [details]
proposed patch

Access to DTDs in the ContentModelManager can't be shared right now since prior attempts at optimization ran across the DOMObservers flushing its collection of DTDs, and it could also trigger side effects from becoming stale with DTDs in the workspace.  This patch limits itself to the HTML component's use of DTDs, and only those contributed from org.eclipse.wst.standard.schemas and org.eclipse.jst.standard.schemas (which I might consider expanding upon in a non-maintenance release).
Comment 2 Nitin Dahyabhai CLA 2008-08-18 13:13:22 EDT 
CCing Raghu since JSF might be affected by the XHTML changes (hopefully, positively).
Comment 3 Nitin Dahyabhai CLA 2008-08-24 10:29:34 EDT 
released