Community
Participate
Working Groups
+++ This bug was initially created as a clone of Bug #235298 +++ Progress reporting in RemoteRunLaunchDelegate currently doesn't use externalized Strings. These should be externalized for NLS translation.
Created attachment 111426 [details] patch that fixes the issue
Hi Martin, can I check in this fix already?
Yes, please go for it. Don't forget updating the plugin and feature version numbers.
You'll also need to externalize the Strings that go into the progress monitor, such as "Launching" or "Downloading".
Martin, feature and plugin have 2.1.1 version number, what should I put as an updated one? 2.1.2? (In reply to comment #3) > Yes, please go for it. Don't forget updating the plugin and feature version > numbers. >
2.1.100 is the right version, since we're in a new development stream. We'll reserve 2.1.2 for the Maintenance branch (TM 3.0.x). http://wiki.eclipse.org/Version_Numbering http://wiki.eclipse.org/API_Central
Done.
You have created duplicate message strings, is it really needed to have 4 copies of the word "Launching" and 2 copies of the work "Downloading" ?
When I was thinking about that, I decided that we might want to change it to something more descriptive in each case, so it's easier to have them separate. If you disagree, I can change it to use the same string for Launching/Downloading everywhere, just let me know. (In reply to comment #8) > You have created duplicate message strings, is it really needed to have 4 > copies of the word "Launching" and 2 copies of the work "Downloading" ? >
Well I just did a quick check for "Downloading" (_2, _11) and I can't see why the progress message should be different whether you're downloading in Run mode or downloading in Debug mode. Actually, _14 could likely also be unified since "Downloading remote file" is not even correct (a local file is downloaded to the remote). It's the same operation, so it should be the same String. For "Launching" (_0, _10, _12, _9) : _0 and _10 are again the same (run mode and debug mode). _9 and _12 are subtasks for the actual Launch action after the download. It might be a good idea to keep these separate since the text could eventually be "Starting Program" and "Starting Debugger", respectively ... why not make that change right away?
(In reply to comment #10) > ... > why not make that > change right away? Done.
