Bug 243878 - first API addition causes cascade of errors
Summary: first API addition causes cascade of errors
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 4.13 M1   Edit
Assignee: Vikas Chandra CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
: 321685 (view as bug list)
Depends on:
Blocks: 549370
  Show dependency tree
 
Reported: 2008-08-12 09:34 EDT by Darin Wright CLA
Modified: 2019-07-18 00:57 EDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Wright CLA 2008-08-12 09:34:21 EDT
The first time new API is added to a plug-in/bundle there is a cascade of errors.

* Add a new API method to a 3.4.100 level bundle
* An error appears saying the @since 3.4 tag is missing
* A quick fix addes the @since tag
* An error appears on the manifest saying new API was added and the bundle version needs to be incremented to 3.5.0
* Quick fix the manifest
* An error appears on the newly added since tag saying it should be 3.5
* Quick fix the since tag, all is well.

On the first API addition, it would be nice to be able to have a quick fix that increments the bundle version and creates an @since tag with the right version number the first time.
Comment 1 Darin Wright CLA 2010-08-04 08:59:14 EDT
*** Bug 321685 has been marked as a duplicate of this bug. ***
Comment 2 Dani Megert CLA 2010-08-04 09:04:39 EDT
Besides the cascade of errors, showing the wrong @since tag in the quick fix is really an issue for (new) developers because they either get uncertain about what the correct @since tag is or about the quality of API tooling. For me this is a major flaw.

Can we look at this for 3.7?
Comment 3 Darin Wright CLA 2010-08-04 09:38:05 EDT
When new API is added to a bundle a developer generally wants to increment the bundle version and add the new @since tag. There may be corner cases where API is being added to a patch release and one wants to suppress minor bundle version increments. However, I'm not sure we should offer a quick fix for such cases, as they are uncommon and go against the Eclipse rules of version numbering.

When there are @since tag problems and bundle version problems, we should probably offer a quick fix that fixes both issues at once - increment the bundle version, and add the @since tag (with new / correct version number). Currently the problems are treated individually. We can still offer a single quick fix for incrementing the bundle version number (i.e. problem on the Manifest).
Comment 4 Darin Wright CLA 2010-08-04 09:39:30 EDT
I think this just requires changes to how the quick fix is generated. Targetting for 3.7.
Comment 5 Eclipse Genie CLA 2019-07-02 18:09:48 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 6 Eclipse Genie CLA 2019-07-03 06:09:25 EDT
New Gerrit change created: https://git.eclipse.org/r/145366
Comment 8 Vikas Chandra CLA 2019-07-03 06:59:32 EDT
>quick fix that increments the bundle version and creates an @since tag with the >right version number the first time.

Done
Comment 9 Eclipse Genie CLA 2019-07-03 09:45:28 EDT
New Gerrit change created: https://git.eclipse.org/r/145396
Comment 11 Vikas Chandra CLA 2019-07-09 04:22:11 EDT
verified on

Version: 2019-09 (4.13)
Build id: I20190708-1800
Comment 12 Eclipse Genie CLA 2019-07-09 07:59:47 EDT
New Gerrit change created: https://git.eclipse.org/r/145682