Community
Participate
Working Groups
Build ID: I20080617-2000 Steps To Reproduce: When for instance org.eclipse.cdt.managedbuilder.internal.core.Tool is unable to create an instance of the "commandLineGenerator" specified in the Tool element of the toolchain declaration a CoreException is thrown which is ignored silently. Instead an event should be logged for debugging purposes.
Created attachment 109754 [details] Patch for logging exceptions when instantiation fails The PLUGIN_ID member variable of ManagedBuilderCorePlugin has been made public and all CoreExceptions thrown when attempting to create instances using instances from the toolchain declaration (in org.eclipse.cdt.managedbuilder.internal.core) are handled using: StatusManager.getManager().handle(e,ManagedBuilderCorePlugin.PLUGIN_ID);
(In reply to comment #1) > The PLUGIN_ID member variable of ManagedBuilderCorePlugin has been made public > and all CoreExceptions thrown when attempting to create instances using > instances from the toolchain declaration (in > org.eclipse.cdt.managedbuilder.internal.core) are handled using: > StatusManager.getManager().handle(e,ManagedBuilderCorePlugin.PLUGIN_ID); I agree that exceptions should be recorded but why do you use StatusManager if everywhere else in the plugin errors are reported via ManagedBuilderCorePlugin.log()? It's been a while and the patch does not apply clean anymore.
Closing as there is no response from submitter. Please reopen if still want to proceed with this.
Sorry about not answering. I missed your reply. I agree that ManagedBuilderCorePlugin.log() should be used instead. It's been a while since my original request to have this fixed so I cannot remember my original motivation to use the StatusManager. I think the problem was that using the CDT logger would just add an entry to the log and not pop up an UI also I think the error log view was still a part of PDE at that time. So that most users will never be aware of a problem unless they actually have PDE installed (unlikely) and checked the view. I have not taken a look the newer code so I don't know if the problem is still there. Reopening for now. I'll see if I can find the time to submit a new patch soon.
Returning to the pool until new patch provided.
