Bug 243727 - during publish of modules only java files are taken
Summary: during publish of modules only java files are taken
Status: CLOSED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 blocker (vote)
Target Milestone: 3.0.1   Edit
Assignee: Janelle Carroll CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords: contributed
Depends on: 237141
Blocks: 245149
  Show dependency tree
 
Reported: 2008-08-11 07:08 EDT by Dimitar Giormov CLA
Modified: 2008-08-25 12:52 EDT (History)
4 users (show)

See Also:
david_williams: pmc_approved+
raghunathan.srinivasan: pmc_approved+
cbridgha: pmc_approved? (naci.dai)
deboer: pmc_approved+
cbridgha: pmc_approved? (neil.hauge)
cbridgha: pmc_approved? (kaloyan)
cbridgha: review+

Attachments
proposed patch (3.25 KB, patch)
2008-08-13 16:59 EDT, Janelle Carroll CLA 		bjorn.freeman-benson: iplog+
Details | Diff
new junit (12.15 KB, patch)
2008-08-13 18:23 EDT, Chuck Bridgham CLA 		bjorn.freeman-benson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitar Giormov CLA 2008-08-11 07:08:22 EDT 
Steps to reproduce:

use glassfish or jboss server.

1. create ejb project 1.4 or 3.0 

2. create a session bean

3. add ejb project to ear (note that export jar works ok)

4. try to deploy the enterprise application.

5. go and check the jar in eclipse temp folder or on server deploy server.

inside the archive are only java files no class files.
Comment 1 Dimitar Giormov CLA 2008-08-11 07:10:16 EDT 
build M-3.0.1-20080808153942
Comment 2 Dimitar Giormov CLA 2008-08-12 04:25:05 EDT 
the problem seems to be in wst.server plugins...
I will keep investigating.
Comment 3 Dimitar Giormov CLA 2008-08-12 07:13:19 EDT 
found the problem
it was caused by the fix of bug 237141
Comment 4 Janelle Carroll CLA 2008-08-13 16:59:41 EDT 
Created attachment 109936 [details]
proposed patch

This passed our adopter tests, but exposed a problem in WTP only. We are adding a junit to cover this. The problem was that the contents of the source folder rather than the output folder were copied to the server.
Comment 5 Janelle Carroll CLA 2008-08-13 17:05:01 EDT 
   * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 
It breaks deployment to servers.  Note, SAP marked this as blocker.

    * Is there a work-around? If so, why do you believe the work-around is insufficient? 
No workaround available

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 
This has been tested in the adopter product. We are also adding a wtp junit test.

    * Give a brief technical overview. Who has reviewed this fix? 
The problem was that the contents of the source folder rather than the output folder were copied to the server.

    * What is the risk associated with this fix? 
Low
Comment 6 Chuck Bridgham CLA 2008-08-13 18:23:17 EDT 
Created attachment 109945 [details]
new junit

This test will catch this failing issue
Comment 7 Chuck Bridgham CLA 2008-08-13 18:24:12 EDT 
approve - tested with new junit
Comment 8 David Williams CLA 2008-08-13 18:48:41 EDT 
Thanks for the JUnit and fix. It does seem relatively safe and is a true blocker, so we do need to fix.
Comment 9 Dimitar Giormov CLA 2008-08-14 04:40:37 EDT 
just tested the patch works great.
Comment 10 Carl Anderson CLA 2008-08-14 13:54:41 EDT 
Committed to R3_0_maintenance for 3.0.1
Comment 11 Dimitar Giormov CLA 2008-08-20 09:57:50 EDT 
tested with M-3.0.1-20080815211125