Bug 243584 - [inline] inline method refactoring started on static field
Summary: [inline] inline method refactoring started on static field
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M2   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-08 09:34 EDT by Dani Megert CLA
Modified: 2008-08-11 05:59 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2008-08-08 09:34:18 EDT 
I20080807-1402.



1. replace BreadcrumbMessages.java with:


	private static Class thisClass= BreadcrumbMessages.class;

	private static final String BUNDLE_NAME= thisClass.getName();

	public static String BreadcrumbItemDropDown_showDropDownMenu_action_toolTip;
	
	static {
		// initialize resource bundle
		NLS.initializeMessages(BUNDLE_NAME, thisClass);
	}

	private BreadcrumbMessages() {
	}

2. select 'thisClass' in "NLS.initializeMessages(BUNDLE_NAME, thisClass);"
3. Refactor > Inline...
==> should not allow to refactor
4. start to refactor all invocations
==> gives tons of wrong edits
Comment 1 Markus Keller CLA 2008-08-11 05:59:09 EDT 
There are basically two problems:

1.) Inline Method wizard should tell which method will be inlined. This is bug 37839.

2.) Inline Method should not be available when the selection is a simple name that is not a method name. I've fixed this in HEAD.