Bug 242085 - NPE in MessageDialog
Summary: NPE in MessageDialog
Status: RESOLVED FIXED
Alias: None
Product: Subversive
Classification: Technology
Component: UI (show other bugs)
Version: 0.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Alexander Gurov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-25 11:04 EDT by Eugene Babikhin CLA
Modified: 2008-07-28 09:54 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Babikhin CLA 2008-07-25 11:04:48 EDT
Build ID: I20080617-2000

Steps To Reproduce:
1. Create a project on a workspace
2. Click Team -> Share Project... in context menu against it
3. Run through Share project wizard, press Finish button


More information:
java.lang.NullPointerException
 at org.eclipse.jface.dialogs.IconAndMessageDialog.getSWTImage(IconAndMessageDialog.java:274)
 at org.eclipse.jface.dialogs.IconAndMessageDialog.getWarningImage(IconAndMessageDialog.java:233)
 at org.eclipse.jface.dialogs.MessageDialog.<init>(MessageDialog.java:153)
 at org.eclipse.team.svn.ui.wizard.ShareProjectWizard$1.prompt(ShareProjectWizard.java:258)
 at org.eclipse.team.svn.core.operation.local.management.ShareProjectOperation.runImpl(ShareProjectOperation.java:159)
 at org.eclipse.team.svn.core.operation.AbstractActionOperation.run(AbstractActionOperation.java:76)
 at org.eclipse.team.svn.core.utility.ProgressMonitorUtility.doTask(ProgressMonitorUtility.java:103)
 at org.eclipse.team.svn.core.operation.CompositeOperation.runImpl(CompositeOperation.java:94)
 at org.eclipse.team.svn.core.operation.AbstractActionOperation.run(AbstractActionOperation.java:76)
 at org.eclipse.team.svn.core.utility.ProgressMonitorUtility.doTask(ProgressMonitorUtility.java:103)
 at org.eclipse.team.svn.core.operation.CompositeOperation.runImpl(CompositeOperation.java:94)
 at org.eclipse.team.svn.core.operation.AbstractActionOperation.run(AbstractActionOperation.java:76)
 at org.eclipse.team.svn.core.operation.LoggedOperation.run(LoggedOperation.java:37)
 at org.eclipse.team.svn.core.utility.ProgressMonitorUtility.doTask(ProgressMonitorUtility.java:103)
 at org.eclipse.team.svn.core.utility.ProgressMonitorUtility.doTaskExternal(ProgressMonitorUtility.java:89)
 at org.eclipse.team.svn.ui.utility.DefaultCancellableOperationWrapper.run(DefaultCancellableOperationWrapper.java:55)
 at org.eclipse.team.svn.ui.utility.SVNTeamOperationWrapper.run(SVNTeamOperationWrapper.java:35)
 at org.eclipse.team.internal.ui.actions.JobRunnableContext.run(JobRunnableContext.java:144)
 at org.eclipse.team.internal.ui.actions.JobRunnableContext$ResourceJob.runInWorkspace(JobRunnableContext.java:72)
 at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38)
 at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
Comment 1 Alexander Gurov CLA 2008-07-28 06:07:44 EDT
The problem is happened while executing the code looks like:

MessageDialog dialog = new MessageDialog(shellObject, title, null, message, MessageDialog.WARNING, new String[] {IDialogConstants.YES_LABEL, IDialogConstants.NO_LABEL}, 0);

So, I think it is related not to Subversive but to Eclipse version into which the Subversive plug-in is installed.
Comment 2 Paul Webster CLA 2008-07-28 09:04:08 EDT
org.eclipse.team.svn.ui.wizard.ShareProjectWizard$1.prompt(ShareProjectWizard.java:258) is not running on the UI thread.

Do you have code around it that puts it into an (a)syncExec(*)?

PW
Comment 3 Alexander Gurov CLA 2008-07-28 09:46:52 EDT
(In reply to comment #2)
Sorry for invalid action and thank you for pointing to this, existing code wraps with syncExec() only the MessageDialog.open() call.
Comment 4 Alexander Gurov CLA 2008-07-28 09:49:32 EDT
Fix will be available in the weekly build.
Comment 5 Eugene Babikhin CLA 2008-07-28 09:54:03 EDT
Thanks for (In reply to comment #4)
> Fix will be available in the weekly build.
> 

Thanks.