Bug 241552 - JavaScript function arguments should be displayed in the HTML editor
Summary: JavaScript function arguments should be displayed in the HTML editor
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 3.0.5   Edit
Assignee: Chris Jaun CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-07-21 11:28 EDT by Alon Peled CLA
Modified: 2010-03-03 11:13 EST (History)
2 users (show)

See Also:
thatnitind: review+

Attachments
Content assist in web pages now obeys the preference for adding method params (10.85 KB, patch)
2009-03-23 16:30 EDT, Chris Jaun CLA 		thatnitind: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alon Peled CLA 2008-07-21 11:28:40 EDT 
When using the code assist, all the functions from included JS file have no arguments displayed.
Once you select an entry, the required parameters are missing and you have no indication that the code entered is invalid.
Comment 1 Alon Peled CLA 2008-07-31 04:39:28 EDT 
The common practice for using JavaScript in HTML is based on includes - I would like to see this bug getting higher priority.
Comment 2 Bradley Childs CLA 2008-11-10 17:02:31 EST 
hi alon,

this is working as designed.  the same function is found inside standalone JS editor (no arguments from other source files only function name)

i'm marking this as enhancement  but i agree it's something we should look at fixing for standalone and HTML/embedded editor.

-brad
Comment 3 Alon Peled CLA 2008-11-11 02:13:22 EST 
AFAIK there is no include inside a JS file, only in HTML files. Therefore it is irrelevant for the JS editor.
I am afraid that an enhancement with P3 priority will never be looked at again.
Comment 4 Bradley Childs CLA 2008-11-11 12:03:19 EST 
the similar situation in standalone javascript is call/use of functions in javascript source files within the same project and marked as source folder or file.

i'll give this higher priority.
Comment 5 Chris Jaun CLA 2009-03-23 16:30:53 EDT 
Created attachment 129638 [details]
Content assist in web pages now obeys the preference for adding method params
Comment 6 Chris Jaun CLA 2009-03-23 16:34:07 EDT 
The content assist collector for web pages never checked the preference for whether to add the method params or not, so it was creating the wrong type of collector object.

Had to change a few things around to get this to work, but it seems to be in good shape now.
Comment 7 Chris Jaun CLA 2009-03-23 16:42:48 EDT 
This fix can go into the 3.0.5 and 3.1 streams.
Comment 8 Nitin Dahyabhai CLA 2009-04-13 22:29:52 EDT 
Released to those streams.  Test well.