Bug 241505 - dNew Library Plug-in wizard should allow to set a BREE
Summary: dNew Library Plug-in wizard should allow to set a BREE
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M1   Edit
Assignee: Jakub Jurkiewicz CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2008-07-21 04:44 EDT by Benjamin Cabé CLA
Modified: 2008-08-03 17:20 EDT (History)
3 users (show)

See Also:

Attachments
mylyn/context/zip (1.00 KB, application/octet-stream)
2008-07-21 04:48 EDT, Benjamin Cabé CLA 		no flags Details
Patch (7.73 KB, text/plain)
2008-07-24 10:32 EDT, Jakub Jurkiewicz CLA 		caniszczyk: iplog+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Cabé CLA 2008-07-21 04:44:36 EDT 
At the moment, when creating a plug-in from library, the user is not asked for a BREE.
It results in a warning in the generated bundle because of no BREE set.
We should consider fixing it for 3.4.1.
Comment 1 Benjamin Cabé CLA 2008-07-21 04:47:14 EDT 
attaching a context for bugday
Comment 2 Benjamin Cabé CLA 2008-07-21 04:47:56 EDT 
context attachment didn't work...?
Comment 3 Benjamin Cabé CLA 2008-07-21 04:48:00 EDT 
Created attachment 107904 [details]
mylyn/context/zip
Comment 4 Jakub Jurkiewicz CLA 2008-07-24 10:32:24 EDT 
Created attachment 108352 [details]
Patch

It's close to the BugDay, so I ave tried to prepare a patch. 
Most of the code is taken from org.eclipse.pde.internal.ui.wizards.plugin.PluginContentPage, so I wonder if maybe this class and org.eclipse.pde.internal.ui.wizards.plugin.NewLibraryPluginCreationPage could be refactored to reuse some parts of the code?
Comment 5 Chris Aniszczyk CLA 2008-07-24 10:35:37 EDT 
bonus points if you can find a way to refactor this code for the PDE wizards ;)
Comment 6 Jakub Jurkiewicz CLA 2008-07-24 11:40:03 EDT 
It's not so easy as I thought at the beginning ;)
I thought that maybe we could extract some super class, but now I see that it is rather impossible. The only possible solution I can see now is to create some extra class which will handle some of the common code, but I'm afraid it could lead to more complicated code. If you have any suggestion I would be happy to hear it and try to refactore this.
Comment 7 Chris Aniszczyk CLA 2008-08-03 17:19:43 EDT 
thanks.

> 20080803
Comment 8 Chris Aniszczyk CLA 2008-08-03 17:19:53 EDT 
done.